Revert of Un-nest configs in GN files.

third_party/sqlite/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 declare_args() {
   # Controls whether the build should uses the version of sqlite3 library
   # shipped with the system (currently only supported on iOS) or the one
   # shipped with Chromium source.
   use_system_sqlite = is_ios
 }
 
 if (!use_system_sqlite) {
   config("sqlite_config") {
     include_dirs = [ "." ]
   }
 
-  config("sqlite_warnings") {
-    cflags = []
-    if (is_clang) {
-      # sqlite contains a few functions that are unused, at least on
-      # Windows with Chromium's sqlite patches applied
-      # (interiorCursorEOF fts3EvalDeferredPhrase
-      # fts3EvalSelectDeferred sqlite3Fts3InitHashTable
-      # sqlite3Fts3InitTok).
-      cflags += [ "-Wno-unused-function" ]
-    }
-    if (is_linux) {
-      cflags += [
-        # SQLite doesn"t believe in compiler warnings,
-        # preferring testing.
-        #   http://www.sqlite.org/faq.html#q17
-        "-Wno-int-to-pointer-cast",
-        "-Wno-pointer-to-int-cast",
-      ]
-    }
-  }
-
   source_set("sqlite") {
     sources = [
       "amalgamation/sqlite3.c",
       "amalgamation/sqlite3.h",
     ]
 
     cflags = []
     defines = [
       "SQLITE_ENABLE_FTS3",
       "SQLITE_DISABLE_FTS3_UNICODE",
@@ skipping 23 matching lines @@
     }
     if (is_linux || is_android) {
       defines += [
         # Linux provides fdatasync(), a faster equivalent of fsync().
         "fdatasync=fdatasync",
       ]
     }
 
     include_dirs = [ "amalgamation" ]
 
+    config("sqlite_warnings") {
+      cflags = []
+      if (is_clang) {
+        # sqlite contains a few functions that are unused, at least on
+        # Windows with Chromium's sqlite patches applied
+        # (interiorCursorEOF fts3EvalDeferredPhrase
+        # fts3EvalSelectDeferred sqlite3Fts3InitHashTable
+        # sqlite3Fts3InitTok).
+        cflags += [ "-Wno-unused-function" ]
+      }
+      if (is_linux) {
+        cflags += [
+          # SQLite doesn"t believe in compiler warnings,
+          # preferring testing.
+          #   http://www.sqlite.org/faq.html#q17
+          "-Wno-int-to-pointer-cast",
+          "-Wno-pointer-to-int-cast",
+        ]
+      }
+    }
     configs -= [ "//build/config/compiler:chromium_code" ]
     configs += [ "//build/config/compiler:no_chromium_code" ]
     configs += [ ":sqlite_warnings" ]
 
     if (is_linux) {
       libs = [ "dl" ]
     } else if (is_mac || is_ios) {
       libs = [ "CoreFoundation.framework" ]
     } else if (is_android) {
       defines += [
@@ skipping 74 matching lines @@
         "//third_party/icu",
       ]
       if (is_clang) {
         # src/ext/icu/icu.c uses assert(!"string") which causes warnings about
         # conversion from string literal to bool.
         configs -= [ "//build/config/clang:extra_warnings" ]
       }
     }
   }
 }