Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: third_party/libxslt/BUILD.gn

Issue 1316843006: Revert of Un-nest configs in GN files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/libxml/BUILD.gn ('k') | third_party/lzma_sdk/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libxslt/BUILD.gn
diff --git a/third_party/libxslt/BUILD.gn b/third_party/libxslt/BUILD.gn
index 1ecb11cf2e2aeee4bcc6f27047788a2c777209e1..6b46db384f56dda1354718f69fa56b5b74767a87 100644
--- a/third_party/libxslt/BUILD.gn
+++ b/third_party/libxslt/BUILD.gn
@@ -5,19 +5,6 @@
config("libxslt_config") {
defines = [ "LIBXSLT_STATIC" ]
include_dirs = [ "." ]
-}
-
-config("libxslt_warnings") {
- if (is_clang) {
- cflags = [
- # libxslt stores a char[3] in a `const unsigned char*`.
- "-Wno-pointer-sign",
-
- # xsltDefaultRegion and xsltCalibrateTimestamps are only
- # used with certain preprocessor defines set.
- "-Wno-unused-function",
- ]
- }
}
static_library("libxslt") {
@@ -72,11 +59,21 @@
"win32/config.h",
]
+ config("libxslt_warnings") {
+ if (is_clang) {
+ cflags = [
+ # libxslt stores a char[3] in a `const unsigned char*`.
+ "-Wno-pointer-sign",
+
+ # xsltDefaultRegion and xsltCalibrateTimestamps are only
+ # used with certain preprocessor defines set.
+ "-Wno-unused-function",
+ ]
+ }
+ }
configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [
- ":libxslt_warnings",
- "//build/config/compiler:no_chromium_code",
- ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
+ configs += [ ":libxslt_warnings" ]
public_configs = [ ":libxslt_config" ]
cflags = []
« no previous file with comments | « third_party/libxml/BUILD.gn ('k') | third_party/lzma_sdk/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698