Extern in .cpp files is a code smell.

Extern in .cpp files is a code smell.

Part 1.  Move to headers so compiler can type check against
the definitions.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/71c15a5e6652952a94ba3a3ef7ac0392e3a06962

[Tom Sepez, 2015-08-18 18:47:30]

Lei, for review. These all seem to line up at link time, but there's no reason
to trust that.

[Tom Sepez, 2015-08-18 19:05:56]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-08-18 19:05:57]

Adding reviewer.

[Lei Zhang, 2015-08-18 22:24:19]

lgtm

https://codereview.chromium.org/1299963002/diff/1/core/src/fpdfapi/fpdf_edit/...
File core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp (right):

https://codereview.chromium.org/1299963002/diff/1/core/src/fpdfapi/fpdf_edit/...
core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:9: #include
"../../../include/fpdfapi/fpdf_parser.h"
alphabetical order

https://codereview.chromium.org/1299963002/diff/1/core/src/fpdftext/unicodeno...
File core/src/fpdftext/unicodenormalization.cpp (right):

https://codereview.chromium.org/1299963002/diff/1/core/src/fpdftext/unicodeno...
core/src/fpdftext/unicodenormalization.cpp:15:
g_UnicodeData_Normalization_Map4};
Is clang-format being weird? I think if you put a comma at the end of the line,
it will put the closing brace on the next line.

[Lei Zhang, 2015-08-18 22:25:56]

CL description: s/chan/can/

[Tom Sepez, 2015-08-19 17:28:54]

Committed patchset #1 (id:1) manually as
71c15a5e6652952a94ba3a3ef7ac0392e3a06962 (presubmit successful).