Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pdfium.gyp

Issue 1299963002: Extern in .cpp files is a code smell. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« core/src/fpdftext/unicodenormalization.cpp ('K') | « fpdfsdk/src/javascript/global.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdfium.gyp
diff --git a/pdfium.gyp b/pdfium.gyp
index 6e48c344352373cd94388cde92be4fe17a07760c..8fc862ceedd6708e977d386860bbc77b8671c1cc 100644
--- a/pdfium.gyp
+++ b/pdfium.gyp
@@ -317,6 +317,7 @@
'core/src/fpdftext/txtproc.h',
'core/src/fpdftext/unicodenormalization.cpp',
'core/src/fpdftext/unicodenormalizationdata.cpp',
+ 'core/src/fpdftext/unicodenormalizationdata.h',
],
},
{
@@ -471,6 +472,7 @@
'core/src/fxge/dib/fx_dib_engine.cpp',
'core/src/fxge/dib/fx_dib_main.cpp',
'core/src/fxge/dib/fx_dib_transform.cpp',
+ 'core/src/fxge/fontdata/chromefontdata/chromefontdata.h',
'core/src/fxge/fontdata/chromefontdata/FoxitDingbats.c',
'core/src/fxge/fontdata/chromefontdata/FoxitFixed.c',
'core/src/fxge/fontdata/chromefontdata/FoxitFixedBold.c',
« core/src/fpdftext/unicodenormalization.cpp ('K') | « fpdfsdk/src/javascript/global.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698