core/src/fxge/fontdata/chromefontdata/FoxitSerifItalic.c - Issue 1299963002: Extern in .cpp files is a code smell.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/src/fxge/fontdata/chromefontdata/FoxitSerifItalic.c

Issue 1299963002: Extern in .cpp files is a code smell. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« core/src/fpdftext/unicodenormalization.cpp ('K') | « core/src/fxge/fontdata/chromefontdata/FoxitSerifBoldItalic.c ('k') | core/src/fxge/fontdata/chromefontdata/FoxitSerifMM.c » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

	7 #include "chromefontdata.h"

	8

7 const unsigned char g_FoxitSerifItalicFontData [21227] = {0x1,	9 const unsigned char g_FoxitSerifItalicFontData [21227] = {0x1,

8 0x0, 0x4, 0x2, 0x0, 0x 1, 0x1, 0x1, 0x15,	10 0x0, 0x4, 0x2, 0x0, 0x 1, 0x1, 0x1, 0x15,

9 0x43, 0x68, 0x72, 0x6f , 0x6d, 0x53, 0x65, 0x72,	11 0x43, 0x68, 0x72, 0x6f , 0x6d, 0x53, 0x65, 0x72,

10 0x69, 0x66, 0x4f, 0x54 , 0x46, 0x2d, 0x49, 0x74,	12 0x69, 0x66, 0x4f, 0x54 , 0x46, 0x2d, 0x49, 0x74,

11 0x61, 0x6c, 0x69, 0x63 , 0x0, 0x1, 0x1, 0x1,	13 0x61, 0x6c, 0x69, 0x63 , 0x0, 0x1, 0x1, 0x1,

12 0x2a, 0xf8, 0x10, 0x0, 0xf8, 0x1c, 0x1, 0xf8,	14 0x2a, 0xf8, 0x10, 0x0, 0xf8, 0x1c, 0x1, 0xf8,

13 0x1d, 0x2, 0xf8, 0x1e, 0x3, 0xf8, 0x18, 0x4,	15 0x1d, 0x2, 0xf8, 0x1e, 0x3, 0xf8, 0x18, 0x4,

14 0x1e, 0xe1, 0x5a, 0x4f , 0xc, 0x2, 0xfb, 0x3c,	16 0x1e, 0xe1, 0x5a, 0x4f , 0xc, 0x2, 0xfb, 0x3c,

15 0xfb, 0x8e, 0xfa, 0x71 , 0xf9, 0xf8, 0x5, 0xf7,	17 0xfb, 0x8e, 0xfa, 0x71 , 0xf9, 0xf8, 0x5, 0xf7,

16 0x3c, 0xf, 0xf8, 0x93, 0x11, 0xb0, 0x1c, 0x46,	18 0x3c, 0xf, 0xf8, 0x93, 0x11, 0xb0, 0x1c, 0x46,

(...skipping 2636 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
2653 0xab, 0xfb, 0x2d, 0xa6 , 0xf9, 0x8e, 0xa6, 0x1,	2655 0xab, 0xfb, 0x2d, 0xa6 , 0xf9, 0x8e, 0xa6, 0x1,

2654 0xb, 0x30, 0xa7, 0x1f, 0x9b, 0x55, 0xb, 0x77,	2656 0xb, 0x30, 0xa7, 0x1f, 0x9b, 0x55, 0xb, 0x77,

2655 0x1, 0xbc, 0xd6, 0x3, 0xb, 0x16, 0xf7, 0x5a,	2657 0x1, 0xbc, 0xd6, 0x3, 0xb, 0x16, 0xf7, 0x5a,

2656 0x9b, 0x6, 0xb, 0x67, 0x6e, 0xa8, 0xaf, 0x1f,	2658 0x9b, 0x6, 0xb, 0x67, 0x6e, 0xa8, 0xaf, 0x1f,

2657 0xb, 0x7b, 0xf7, 0xa5, 0x9b, 0x7, 0xb, 0x15,	2659 0xb, 0x7b, 0xf7, 0xa5, 0x9b, 0x7, 0xb, 0x15,

2658 0x9b, 0xa, 0xb, 0x9b, 0xfb, 0x51, 0x7b, 0x7,	2660 0x9b, 0xa, 0xb, 0x9b, 0xfb, 0x51, 0x7b, 0x7,

2659 0xb, 0xac, 0xf7, 0x97, 0xac, 0xb, 0xc4, 0xa7,	2661 0xb, 0xac, 0xf7, 0x97, 0xac, 0xb, 0xc4, 0xa7,

2660 0xd4, 0xb, 0x9b, 0xfb, 0x5b, 0xb, 0x1b, 0x83,	2662 0xd4, 0xb, 0x9b, 0xfb, 0x5b, 0xb, 0x1b, 0x83,

2661 0x85, 0xb	2663 0x85, 0xb

2662 };	2664 };

OLD	NEW