core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp - Issue 1299963002: Extern in .cpp files is a code smell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp

Issue 1299963002: Extern in .cpp files is a code smell. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp

diff --git a/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp b/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp

index ca6c04fef980b3f173aeb6447d3ee231e370b7be..b1aedaad50861897a8d68df3b8446ddb0dd45b0c 100644

--- a/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp

+++ b/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp

@@ -12,11 +12,6 @@

#include "../fpdf_cmaps/cmap_int.h"

#include "font_int.h"

-extern short TT2PDF(int m, FXFT_Face face);

-extern FX_BOOL FT_UseTTCharmap(FXFT_Face face,

- int platform_id,

- int encoding_id);

CPDF_CMapManager::CPDF_CMapManager() {

m_bPrompted = FALSE;

FXSYS_memset(m_CID2UnicodeMaps, 0, sizeof m_CID2UnicodeMaps);