core/src/fxge/fontdata/chromefontdata/FoxitSans.c - Issue 1299963002: Extern in .cpp files is a code smell.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/src/fxge/fontdata/chromefontdata/FoxitSans.c

Issue 1299963002: Extern in .cpp files is a code smell. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« core/src/fpdftext/unicodenormalization.cpp ('K') | « core/src/fxge/fontdata/chromefontdata/FoxitFixedItalic.c ('k') | core/src/fxge/fontdata/chromefontdata/FoxitSansBold.c » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

	7 #include "chromefontdata.h"

	8

7 const unsigned char g_FoxitSansFontData [15025] = {0x1,	9 const unsigned char g_FoxitSansFontData [15025] = {0x1,

8 0x0, 0x4, 0x2, 0x0, 0x1, 0x1, 0x1, 0xd,	10 0x0, 0x4, 0x2, 0x0, 0x1, 0x1, 0x1, 0xd,

9 0x43, 0x68, 0x72, 0x6f, 0x6d, 0x53, 0x61, 0x6e,	11 0x43, 0x68, 0x72, 0x6f, 0x6d, 0x53, 0x61, 0x6e,

10 0x73, 0x4f, 0x54, 0x46, 0x0, 0x1, 0x1, 0x1,	12 0x73, 0x4f, 0x54, 0x46, 0x0, 0x1, 0x1, 0x1,

11 0x24, 0xf8, 0x10, 0x0, 0xf8, 0x1c, 0x1, 0xf8,	13 0x24, 0xf8, 0x10, 0x0, 0xf8, 0x1c, 0x1, 0xf8,

12 0x1d, 0x2, 0xf8, 0x1d, 0x3, 0 xf8, 0x18, 0x4,	14 0x1d, 0x2, 0xf8, 0x1d, 0x3, 0 xf8, 0x18, 0x4,

13 0xfb, 0x3a, 0xfb, 0x75, 0xfa, 0x7c, 0xfa, 0x45,	15 0xfb, 0x3a, 0xfb, 0x75, 0xfa, 0x7c, 0xfa, 0x45,

14 0x5, 0xf7, 0x16, 0xf, 0xf8, 0 xe1, 0x11, 0xab,	16 0x5, 0xf7, 0x16, 0xf, 0xf8, 0 xe1, 0x11, 0xab,

15 0x1c, 0x34, 0xa2, 0x12, 0x0, 0x3, 0x1, 0x1,	17 0x1c, 0x34, 0xa2, 0x12, 0x0, 0x3, 0x1, 0x1,

16 0x5, 0x2f, 0x3d, 0x45, 0x75, 0x72, 0x6f, 0x20,	18 0x5, 0x2f, 0x3d, 0x45, 0x75, 0x72, 0x6f, 0x20,

(...skipping 1860 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1877 0xf8, 0x62, 0xd7, 0x12, 0xcc, 0xe3, 0xb, 0xfb,	1879 0xf8, 0x62, 0xd7, 0x12, 0xcc, 0xe3, 0xb, 0xfb,

1878 0xfa, 0xfb, 0x4e, 0x76, 0xfa, 0x40, 0x77, 0xb,	1880 0xfa, 0xfb, 0x4e, 0x76, 0xfa, 0x40, 0x77, 0xb,

1879 0x20, 0xab, 0x76, 0xf8, 0x78, 0x77, 0x1, 0xbb,	1881 0x20, 0xab, 0x76, 0xf8, 0x78, 0x77, 0x1, 0xbb,

1880 0xb, 0x27, 0x31, 0xa, 0xe, 0x 5a, 0x58, 0x68,	1882 0xb, 0x27, 0x31, 0xa, 0xe, 0x 5a, 0x58, 0x68,

1881 0x3e, 0x8c, 0x1f, 0xe, 0xf7, 0x1d, 0x59, 0xa,	1883 0x3e, 0x8c, 0x1f, 0xe, 0xf7, 0x1d, 0x59, 0xa,

1882 0xf7, 0x5, 0x8a, 0x77, 0x12, 0xb, 0x7d, 0xd3,	1884 0xf7, 0x5, 0x8a, 0x77, 0x12, 0xb, 0x7d, 0xd3,

1883 0xf8, 0x2a, 0xd3, 0xb, 0xb8, 0xe5, 0xf7, 0xb2,	1885 0xf8, 0x2a, 0xd3, 0xb, 0xb8, 0xe5, 0xf7, 0xb2,

1884 0xe5, 0xb, 0xf7, 0x54, 0xd9, 0xfb, 0x54, 0xb,	1886 0xe5, 0xb, 0xf7, 0x54, 0xd9, 0xfb, 0x54, 0xb,

1885 0x7c, 0xd7, 0x60, 0x76, 0xb, 0x33, 0x6, 0xe	1887 0x7c, 0xd7, 0x60, 0x76, 0xb, 0x33, 0x6, 0xe

1886 };	1888 };

OLD	NEW