core/src/fxge/fontdata/chromefontdata/chromefontdata.h - Issue 1299963002: Extern in .cpp files is a code smell.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/src/fxge/fontdata/chromefontdata/chromefontdata.h

Issue 1299963002: Extern in .cpp files is a code smell. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 PDFium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

	6

	7 #ifndef CORE_SRC_FXGE_FONTDATA_CHROMEFONTDATA_CHROMEFONTDATA_H_

	8 #define CORE_SRC_FXGE_FONTDATA_CHROMEFONTDATA_CHROMEFONTDATA_H_

	9

	10 #ifdef __cplusplus

	11 extern "C" {

	12 #endif

	13

	14 extern const unsigned char g_FoxitFixedItalicFontData[18746];

	15 extern const unsigned char g_FoxitFixedFontData[17597];

	16 extern const unsigned char g_FoxitSansItalicFontData[16339];

	17 extern const unsigned char g_FoxitSansFontData[15025];

	18 extern const unsigned char g_FoxitSerifItalicFontData[21227];

	19 extern const unsigned char g_FoxitSerifFontData[19469];

	20 extern const unsigned char g_FoxitFixedBoldItalicFontData[19151];

	21 extern const unsigned char g_FoxitFixedBoldFontData[18055];

	22 extern const unsigned char g_FoxitSansBoldItalicFontData[16418];

	23 extern const unsigned char g_FoxitSansBoldFontData[16344];

	24 extern const unsigned char g_FoxitSerifBoldItalicFontData[20733];

	25 extern const unsigned char g_FoxitSerifBoldFontData[19395];

	26 extern const unsigned char g_FoxitSymbolFontData[16729];

	27 extern const unsigned char g_FoxitDingbatsFontData[29513];

	28 extern const unsigned char g_FoxitSerifMMFontData[113417];

	29 extern const unsigned char g_FoxitSansMMFontData[66919];

	30

	31 #ifdef __cplusplus

	32 } // extern "C"

	33 #endif

	34

	35 #endif // CORE_SRC_FXGE_FONTDATA_CHROMEFONTDATA_CHROMEFONTDATA_H_

OLD	NEW

« core/src/fpdftext/unicodenormalization.cpp ('K') | « core/src/fxge/fontdata/chromefontdata/FoxitSymbol.c ('k') | core/src/fxge/ge/fx_ge_fontmap.cpp » ('j') | no next file with comments »