core/src/fxge/fontdata/chromefontdata/FoxitSerifBoldItalic.c - Issue 1299963002: Extern in .cpp files is a code smell.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/src/fxge/fontdata/chromefontdata/FoxitSerifBoldItalic.c

Issue 1299963002: Extern in .cpp files is a code smell. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« core/src/fpdftext/unicodenormalization.cpp ('K') | « core/src/fxge/fontdata/chromefontdata/FoxitSerifBold.c ('k') | core/src/fxge/fontdata/chromefontdata/FoxitSerifItalic.c » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

	7 #include "chromefontdata.h"

	8

7 const unsigned char g_FoxitSerifBoldItalicFontData [20733] = {0x1,	9 const unsigned char g_FoxitSerifBoldItalicFontData [20733] = {0x1,

8 0x0, 0x4, 0x2, 0x0 , 0x1, 0x1, 0x1, 0x19,	10 0x0, 0x4, 0x2, 0x0 , 0x1, 0x1, 0x1, 0x19,

9 0x43, 0x68, 0x72, 0x6f, 0x6d, 0x53, 0x65, 0x72,	11 0x43, 0x68, 0x72, 0x6f, 0x6d, 0x53, 0x65, 0x72,

10 0x69, 0x66, 0x4f, 0x54, 0x46, 0x2d, 0x42, 0x6f,	12 0x69, 0x66, 0x4f, 0x54, 0x46, 0x2d, 0x42, 0x6f,

11 0x6c, 0x64, 0x49, 0x74, 0x61, 0x6c, 0x69, 0x63,	13 0x6c, 0x64, 0x49, 0x74, 0x61, 0x6c, 0x69, 0x63,

12 0x0, 0x1, 0x1, 0x1 , 0x29, 0xf8, 0x10, 0x0,	14 0x0, 0x1, 0x1, 0x1 , 0x29, 0xf8, 0x10, 0x0,

13 0xf8, 0x1c, 0x1, 0 xf8, 0x1d, 0x2, 0xf8, 0x1e,	15 0xf8, 0x1c, 0x1, 0 xf8, 0x1d, 0x2, 0xf8, 0x1e,

14 0x3, 0xf8, 0x14, 0 x4, 0x7d, 0xc, 0x2, 0xfb,	16 0x3, 0xf8, 0x14, 0 x4, 0x7d, 0xc, 0x2, 0xfb,

15 0x5c, 0xfb, 0x8e, 0xfa, 0x6e, 0xf9, 0xf9, 0x5,	17 0x5c, 0xfb, 0x8e, 0xfa, 0x6e, 0xf9, 0xf9, 0x5,

16 0x1c, 0x6, 0xf6, 0 xf, 0x1c, 0x8, 0x4d, 0x11,	18 0x1c, 0x6, 0xf6, 0 xf, 0x1c, 0x8, 0x4d, 0x11,

(...skipping 2574 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
2591 0x5, 0x84, 0x9c, 0 xb, 0x8b, 0x69, 0x1b, 0x66,	2593 0x5, 0x84, 0x9c, 0 xb, 0x8b, 0x69, 0x1b, 0x66,

2592 0xf7, 0x8d, 0xb0, 0x7, 0x68, 0xb, 0x72, 0x58,	2594 0xf7, 0x8d, 0xb0, 0x7, 0x68, 0xb, 0x72, 0x58,

2593 0xfb, 0x39, 0x58, 0xfb, 0x53, 0x1e, 0xb, 0x76,	2595 0xfb, 0x39, 0x58, 0xfb, 0x53, 0x1e, 0xb, 0x76,

2594 0x54, 0xa, 0xb, 0x fb, 0xce, 0xfb, 0x3a, 0x76,	2596 0x54, 0xa, 0xb, 0x fb, 0xce, 0xfb, 0x3a, 0x76,

2595 0xf9, 0xfd, 0x77, 0xb, 0x1a, 0x87, 0x8a, 0x86,	2597 0xf9, 0xfd, 0x77, 0xb, 0x1a, 0x87, 0x8a, 0x86,

2596 0x8a, 0xb, 0x15, 0 xf7, 0x74, 0x9e, 0x6, 0xb,	2598 0x8a, 0xb, 0x15, 0 xf7, 0x74, 0x9e, 0x6, 0xb,

2597 0xf7, 0x40, 0x5, 0 xc6, 0xcd, 0xb, 0xf7, 0x1a,	2599 0xf7, 0x40, 0x5, 0 xc6, 0xcd, 0xb, 0xf7, 0x1a,

2598 0xd5, 0xf7, 0x1a, 0xb, 0x74, 0x88, 0x1d, 0xb,	2600 0xd5, 0xf7, 0x1a, 0xb, 0x74, 0x88, 0x1d, 0xb,

2599 0x15, 0xcb, 0xbd, 0xb	2601 0x15, 0xcb, 0xbd, 0xb

2600 };	2602 };

OLD	NEW