Extern in .cpp files is a code smell.

core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

Index: core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp
diff --git a/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp b/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp
index 668c70b2430408d1a308096c5d101aee05fc032e..4e6c72355d168dd5a5cdef928c2a1fe6237934ff 100644
--- a/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp
+++ b/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp
@@ -6,23 +6,12 @@
 
 #include "../../../include/fxcrt/fx_ext.h"
 #include "../../../include/fpdfapi/fpdf_serial.h"
+#include "../../../include/fpdfapi/fpdf_parser.h"

[Lei Zhang, 2015/08/18 22:24:19]

alphabetical order

 #include "editint.h"
 
 #define PDF_OBJECTSTREAM_MAXLENGTH (256 * 1024)
 #define PDF_XREFSTREAM_MAXSIZE 10000
-extern void FlateEncode(const uint8_t* src_buf,
-                        FX_DWORD src_data,
-                        uint8_t*& dest_buf,
-                        FX_DWORD& dest_size);
-extern void FlateEncode(const uint8_t* src_buf,
-                        FX_DWORD src_size,
-                        int predictor,
-                        int Colors,
-                        int BitsPerComponent,
-                        int Columns,
-                        uint8_t*& dest_buf,
-                        FX_DWORD& dest_size);
-extern FX_BOOL IsSignatureDict(const CPDF_Dictionary* pDict);
+
 int32_t PDF_CreatorAppendObject(const CPDF_Object* pObj,
                                 CFX_FileBufferArchive* pFile,
                                 FX_FILESIZE& offset) {