core/src/fxge/fontdata/chromefontdata/FoxitSansMM.c - Issue 1299963002: Extern in .cpp files is a code smell.

Side by Side Diff: core/src/fxge/fontdata/chromefontdata/FoxitSansMM.c

Issue 1299963002: Extern in .cpp files is a code smell. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« core/src/fpdftext/unicodenormalization.cpp ('K') | « core/src/fxge/fontdata/chromefontdata/FoxitSansItalic.c ('k') | core/src/fxge/fontdata/chromefontdata/FoxitSerif.c » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

	7 #include "chromefontdata.h"

	8

7 const unsigned char g_FoxitSansMMFontData [66919] = {	9 const unsigned char g_FoxitSansMMFontData [66919] = {

8 0x80, 0x01, 0xD2, 0x29, 0x00, 0x00, 0x25, 0x21, 0x50, 0x53, 0x2D, 0x41, 0x64 , 0x6F, 0x62, 0x65,	10 0x80, 0x01, 0xD2, 0x29, 0x00, 0x00, 0x25, 0x21, 0x50, 0x53, 0x2D, 0x41, 0x64 , 0x6F, 0x62, 0x65,

9 0x46, 0x6F, 0x6E, 0x74, 0x2D, 0x31, 0x2E, 0x30, 0x3A, 0x20, 0x43, 0x68, 0x72 , 0x6f, 0x6d, 0x65, 0x53,	11 0x46, 0x6F, 0x6E, 0x74, 0x2D, 0x31, 0x2E, 0x30, 0x3A, 0x20, 0x43, 0x68, 0x72 , 0x6f, 0x6d, 0x65, 0x53,

10 0x61, 0x6E, 0x73, 0x4D, 0x4D, 0x20, 0x30, 0x30, 0x31, 0x2E, 0x30, 0x30, 0x30 , 0x0D, 0x25, 0x25,	12 0x61, 0x6E, 0x73, 0x4D, 0x4D, 0x20, 0x30, 0x30, 0x31, 0x2E, 0x30, 0x30, 0x30 , 0x0D, 0x25, 0x25,

11 0x43, 0x72, 0x65, 0x61, 0x74, 0x69, 0x6F, 0x6E, 0x44, 0x61, 0x74, 0x65, 0x3A , 0x20, 0x46, 0x72,	13 0x43, 0x72, 0x65, 0x61, 0x74, 0x69, 0x6F, 0x6E, 0x44, 0x61, 0x74, 0x65, 0x3A , 0x20, 0x46, 0x72,

12 0x69, 0x20, 0x53, 0x65, 0x70, 0x20, 0x32, 0x39, 0x20, 0x31, 0x36, 0x3A, 0x30 , 0x32, 0x3A, 0x35,	14 0x69, 0x20, 0x53, 0x65, 0x70, 0x20, 0x32, 0x39, 0x20, 0x31, 0x36, 0x3A, 0x30 , 0x32, 0x3A, 0x35,

13 0x33, 0x20, 0x32, 0x30, 0x30, 0x36, 0x0D, 0x25, 0x25, 0x56, 0x4D, 0x75, 0x73 , 0x61, 0x67, 0x65,	15 0x33, 0x20, 0x32, 0x30, 0x30, 0x36, 0x0D, 0x25, 0x25, 0x56, 0x4D, 0x75, 0x73 , 0x61, 0x67, 0x65,

14 0x3A, 0x20, 0x31, 0x32, 0x30, 0x30, 0x30, 0x30, 0x20, 0x31, 0x35, 0x30, 0x30 , 0x30, 0x30, 0x0D,	16 0x3A, 0x20, 0x31, 0x32, 0x30, 0x30, 0x30, 0x30, 0x20, 0x31, 0x35, 0x30, 0x30 , 0x30, 0x30, 0x0D,

15 0x31, 0x37, 0x20, 0x64, 0x69, 0x63, 0x74, 0x20, 0x62, 0x65, 0x67, 0x69, 0x6E , 0x0D, 0x2F, 0x46,	17 0x31, 0x37, 0x20, 0x64, 0x69, 0x63, 0x74, 0x20, 0x62, 0x65, 0x67, 0x69, 0x6E , 0x0D, 0x2F, 0x46,

16 0x6F, 0x6E, 0x74, 0x49, 0x6E, 0x66, 0x6F, 0x20, 0x31, 0x34, 0x20, 0x64, 0x69 , 0x63, 0x74, 0x20,	18 0x6F, 0x6E, 0x74, 0x49, 0x6E, 0x66, 0x6F, 0x20, 0x31, 0x34, 0x20, 0x64, 0x69 , 0x63, 0x74, 0x20,

(...skipping 4165 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
4182 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30 , 0x30, 0x30, 0x30,	4184 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30 , 0x30, 0x30, 0x30,

4183 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30 , 0x30, 0x30, 0x30,	4185 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30 , 0x30, 0x30, 0x30,

4184 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30 , 0x30, 0x30, 0x30,	4186 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30 , 0x30, 0x30, 0x30,

4185 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x0D, 0x30, 0x30, 0x30, 0x30, 0x30 , 0x30, 0x30, 0x30,	4187 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x0D, 0x30, 0x30, 0x30, 0x30, 0x30 , 0x30, 0x30, 0x30,

4186 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30 , 0x30, 0x30, 0x30,	4188 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30 , 0x30, 0x30, 0x30,

4187 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30 , 0x30, 0x30, 0x30,	4189 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30 , 0x30, 0x30, 0x30,

4188 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30 , 0x30, 0x30, 0x30,	4190 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30 , 0x30, 0x30, 0x30,

4189 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x0D, 0x63, 0x6C, 0x65, 0x61 , 0x72, 0x74, 0x6F,	4191 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x0D, 0x63, 0x6C, 0x65, 0x61 , 0x72, 0x74, 0x6F,

4190 0x6D, 0x61, 0x72, 0x6B, 0x0D, 0x80, 0x03,	4192 0x6D, 0x61, 0x72, 0x6B, 0x0D, 0x80, 0x03,

4191 };	4193 };

OLD	NEW