base: Remove using:: declaration from version.h header.

base: Remove using:: declaration from version.h header.

BUG=None
R=brettw@chromium.org

Committed: https://crrev.com/9c2f5dc9c732beb936b41d073bf5ec7adefb0872
Cr-Commit-Position: refs/heads/master@{#344088}

[tfarina, 2015-08-12 01:18:32]

tfarina@chromium.org changed reviewers:
+ brettw@chromium.org
- thestig@chromium.org

[tfarina, 2015-08-12 22:00:35]

I think this is ready for review.

Brett, could you review this to me?

After this point I hope to fix the bots for the other platforms and submit with
your approval.

[brettw, 2015-08-13 18:24:35]

neato, lgtm

https://codereview.chromium.org/1281313003/diff/140001/chrome/browser/plugins...
File chrome/browser/plugins/plugin_metadata.cc (right):

https://codereview.chromium.org/1281313003/diff/140001/chrome/browser/plugins...
chrome/browser/plugins/plugin_metadata.cc:109: std::map<base::Version,
SecurityStatus, VersionComparator>::const_iterator
Can you just change this to auto it = versions_....

https://codereview.chromium.org/1281313003/diff/140001/components/update_clie...
File components/update_client/test_installer.cc (right):

https://codereview.chromium.org/1281313003/diff/140001/components/update_clie...
components/update_client/test_installer.cc:65: base::Version
version(version_string.c_str());
Remove the .c_str() here since it just makes an unnecessary intermediate string

[tfarina, 2015-08-18 01:50:46]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-08-18 01:50:47]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1281313003/#ps220001
(title: "mac fixes")

[commit-bot: I haz the power, 2015-08-18 01:51:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1281313003/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1281313003/220001

[commit-bot: I haz the power, 2015-08-18 02:17:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 02:17:39]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tfarina, 2015-08-18 02:20:56]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-08-18 02:20:57]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1281313003/#ps240001
(title: "chromeos fix")

[commit-bot: I haz the power, 2015-08-18 02:22:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1281313003/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1281313003/240001

[commit-bot: I haz the power, 2015-08-18 02:46:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 02:46:49]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tfarina, 2015-08-18 03:35:10]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-08-18 03:35:11]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1281313003/#ps260001
(title: "win fixes")

[commit-bot: I haz the power, 2015-08-18 03:35:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1281313003/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1281313003/260001

[commit-bot: I haz the power, 2015-08-18 03:56:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 03:56:51]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tfarina, 2015-08-18 04:02:23]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-08-18 04:02:24]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1281313003/#ps280001
(title: "more win fixes")

[commit-bot: I haz the power, 2015-08-18 04:03:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1281313003/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1281313003/280001

[commit-bot: I haz the power, 2015-08-18 04:33:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 04:33:42]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tfarina, 2015-08-18 15:43:58]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-08-18 15:43:58]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1281313003/#ps300001
(title: "win fixes")

[commit-bot: I haz the power, 2015-08-18 15:44:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1281313003/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1281313003/300001

[commit-bot: I haz the power, 2015-08-18 16:24:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 16:24:08]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tfarina, 2015-08-18 16:44:08]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-08-18 16:44:08]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1281313003/#ps320001
(title: "more win fixes")

[commit-bot: I haz the power, 2015-08-18 16:44:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1281313003/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1281313003/320001

[commit-bot: I haz the power, 2015-08-18 17:14:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 17:14:45]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[tfarina, 2015-08-18 17:59:51]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-08-18 17:59:52]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1281313003/#ps340001
(title: "fixes")

[commit-bot: I haz the power, 2015-08-18 18:00:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1281313003/340001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1281313003/340001

[tfarina, 2015-08-18 18:33:39]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-08-18 18:33:40]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1281313003/#ps360001
(title: "more fixes")

[commit-bot: I haz the power, 2015-08-18 18:34:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1281313003/360001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1281313003/360001

[commit-bot: I haz the power, 2015-08-18 19:12:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 19:12:01]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tfarina, 2015-08-18 19:33:27]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-08-18 19:33:28]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1281313003/#ps380001
(title: "more and more")

[commit-bot: I haz the power, 2015-08-18 19:33:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1281313003/380001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1281313003/380001

[commit-bot: I haz the power, 2015-08-18 20:04:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 20:04:04]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[tfarina, 2015-08-18 20:10:02]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-08-18 20:10:02]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1281313003/#ps400001
(title: "win")

[commit-bot: I haz the power, 2015-08-18 20:10:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1281313003/400001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1281313003/400001

[commit-bot: I haz the power, 2015-08-18 20:44:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 20:44:57]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tfarina, 2015-08-18 21:02:32]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-08-18 21:02:33]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1281313003/#ps410001
(title: "win - will this end?")

[commit-bot: I haz the power, 2015-08-18 21:03:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1281313003/410001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1281313003/410001

[tfarina, 2015-08-18 21:32:02]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-08-18 21:32:02]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1281313003/#ps430001
(title: "almost there")

[commit-bot: I haz the power, 2015-08-18 21:33:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1281313003/430001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1281313003/430001

[commit-bot: I haz the power, 2015-08-18 22:13:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 22:13:24]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[tfarina, 2015-08-18 22:26:30]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-08-18 22:26:31]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1281313003/#ps450001
(title: "more fixes")

[commit-bot: I haz the power, 2015-08-18 22:26:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1281313003/450001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1281313003/450001

[commit-bot: I haz the power, 2015-08-19 00:05:10]

Committed patchset #24 (id:450001)

[commit-bot: I haz the power, 2015-08-19 00:05:58]

Patchset 24 (id:??) landed as
https://crrev.com/9c2f5dc9c732beb936b41d073bf5ec7adefb0872
Cr-Commit-Position: refs/heads/master@{#344088}

[Nico, 2015-08-19 03:25:36]

A revert of this CL (patchset #24 id:450001) has been created in
https://codereview.chromium.org/1301883002/ by thakis@chromium.org.

The reason for reverting is: Broke all official bots, e.g.
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/bu...

c:\b\build\slave\google-chrome-rel-win\build\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(326)
:error C3861: 'Version': identifier not found
.