Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: chrome/installer/util/google_chrome_distribution.cc

Issue 1281313003: base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more fixes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file defines specific implementation of BrowserDistribution class for 5 // This file defines specific implementation of BrowserDistribution class for
6 // Google Chrome. 6 // Google Chrome.
7 7
8 #include "chrome/installer/util/google_chrome_distribution.h" 8 #include "chrome/installer/util/google_chrome_distribution.h"
9 9
10 #include <windows.h> 10 #include <windows.h>
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 scoped_ptr<AppRegistrationData>( 63 scoped_ptr<AppRegistrationData>(
64 new UpdatingAppRegistrationData(kChromeGuid))) { 64 new UpdatingAppRegistrationData(kChromeGuid))) {
65 } 65 }
66 66
67 GoogleChromeDistribution::GoogleChromeDistribution( 67 GoogleChromeDistribution::GoogleChromeDistribution(
68 scoped_ptr<AppRegistrationData> app_reg_data) 68 scoped_ptr<AppRegistrationData> app_reg_data)
69 : BrowserDistribution(CHROME_BROWSER, app_reg_data.Pass()) { 69 : BrowserDistribution(CHROME_BROWSER, app_reg_data.Pass()) {
70 } 70 }
71 71
72 void GoogleChromeDistribution::DoPostUninstallOperations( 72 void GoogleChromeDistribution::DoPostUninstallOperations(
73 const Version& version, 73 const base::Version& version,
74 const base::FilePath& local_data_path, 74 const base::FilePath& local_data_path,
75 const base::string16& distribution_data) { 75 const base::string16& distribution_data) {
76 // Send the Chrome version and OS version as params to the form. 76 // Send the Chrome version and OS version as params to the form.
77 // It would be nice to send the locale, too, but I don't see an 77 // It would be nice to send the locale, too, but I don't see an
78 // easy way to get that in the existing code. It's something we 78 // easy way to get that in the existing code. It's something we
79 // can add later, if needed. 79 // can add later, if needed.
80 // We depend on installed_version.GetString() not having spaces or other 80 // We depend on installed_version.GetString() not having spaces or other
81 // characters that need escaping: 0.2.13.4. Should that change, we will 81 // characters that need escaping: 0.2.13.4. Should that change, we will
82 // need to escape the string before using it in a URL. 82 // need to escape the string before using it in a URL.
83 const base::string16 kVersionParam = L"crversion"; 83 const base::string16 kVersionParam = L"crversion";
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 GetAppGuid()); 265 GetAppGuid());
266 } 266 }
267 267
268 bool GoogleChromeDistribution::ShouldSetExperimentLabels() { 268 bool GoogleChromeDistribution::ShouldSetExperimentLabels() {
269 return true; 269 return true;
270 } 270 }
271 271
272 bool GoogleChromeDistribution::HasUserExperiments() { 272 bool GoogleChromeDistribution::HasUserExperiments() {
273 return true; 273 return true;
274 } 274 }
OLDNEW
« no previous file with comments | « chrome/installer/util/google_chrome_distribution.h ('k') | chrome/installer/util/google_chrome_distribution_dummy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698