Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5505)

Unified Diff: chrome/browser/extensions/webstore_installer.cc

Issue 1281313003: base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more fixes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/webstore_installer.h ('k') | chrome/browser/hang_monitor/hung_plugin_action.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/webstore_installer.cc
diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc
index 6ab5475321b80b78b06a110033e03dd770168ce5..53ce4dd5e34386e32223e697f49736d4e7f2d12e 100644
--- a/chrome/browser/extensions/webstore_installer.cc
+++ b/chrome/browser/extensions/webstore_installer.cc
@@ -418,7 +418,7 @@ void WebstoreInstaller::OnExtensionInstalled(
CHECK_EQ(extension->id(), id_);
ReportSuccess();
} else {
- const Version version_required(info.minimum_version);
+ const base::Version version_required(info.minimum_version);
if (version_required.IsValid() &&
extension->version()->CompareTo(version_required) < 0) {
// It should not happen, CrxInstaller will make sure the version is
@@ -490,11 +490,10 @@ void WebstoreInstaller::OnDownloadStarted(
scoped_ptr<Approval> approval = Approval::CreateForSharedModule(profile_);
const SharedModuleInfo::ImportInfo& info = pending_modules_.front();
approval->extension_id = info.extension_id;
- const Version version_required(info.minimum_version);
+ const base::Version version_required(info.minimum_version);
if (version_required.IsValid()) {
- approval->minimum_version.reset(
- new Version(version_required));
+ approval->minimum_version.reset(new base::Version(version_required));
}
download_item_->SetUserData(kApprovalKey, approval.release());
} else {
« no previous file with comments | « chrome/browser/extensions/webstore_installer.h ('k') | chrome/browser/hang_monitor/hung_plugin_action.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698