chrome/browser/extensions/external_registry_loader_win.cc - Issue 1281313003: base: Remove using:: declaration from version.h header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_registry_loader_win.cc

Issue 1281313003: base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more fixes Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/external_registry_loader_win.cc

diff --git a/chrome/browser/extensions/external_registry_loader_win.cc b/chrome/browser/extensions/external_registry_loader_win.cc

index 0b5a67f83687c838b7723790af6f0953dc435e9f..0f45a8a9b5ccc37fc59cedef4d75c224dbeefcdb 100644

--- a/chrome/browser/extensions/external_registry_loader_win.cc

+++ b/chrome/browser/extensions/external_registry_loader_win.cc

@@ -164,7 +164,7 @@ void ExternalRegistryLoader::LoadOnFileThread() {

continue;

}

- Version version(base::UTF16ToASCII(extension_version));

+ base::Version version(base::UTF16ToASCII(extension_version));

if (!version.IsValid()) {

LOG(ERROR) << "Invalid version value " << extension_version

<< " for key " << key_path << ".";

« no previous file with comments | « chrome/browser/extensions/external_provider_impl.cc ('k') | chrome/browser/extensions/pending_extension_info.h » ('j') | no next file with comments »