base: Remove using:: declaration from version.h header.

chrome/browser/plugins/plugin_metadata.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/plugins/plugin_metadata.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/strings/pattern.h"
@@ skipping 24 matching lines @@
       group_name_matcher_(group_name_matcher),
       url_for_display_(url_for_display),
       plugin_url_(plugin_url),
       help_url_(help_url),
       language_(language) {
 }
 
 PluginMetadata::~PluginMetadata() {
 }
 
-void PluginMetadata::AddVersion(const Version& version,
+void PluginMetadata::AddVersion(const base::Version& version,
                                 SecurityStatus status) {
   DCHECK(versions_.find(version) == versions_.end());
   versions_[version] = status;
 }
 
 void PluginMetadata::AddMimeType(const std::string& mime_type) {
   all_mime_types_.push_back(mime_type);
 }
 
 void PluginMetadata::AddMatchingMimeType(const std::string& mime_type) {
@@ skipping 37 matching lines @@
   return true;
 }
 
 PluginMetadata::SecurityStatus PluginMetadata::GetSecurityStatus(
     const content::WebPluginInfo& plugin) const {
   if (versions_.empty()) {
     // Unknown plugins require authorization.
     return SECURITY_STATUS_REQUIRES_AUTHORIZATION;
   }
 
-  Version version;
+  base::Version version;
   content::WebPluginInfo::CreateVersionFromString(plugin.version, &version);
   if (!version.IsValid())
-    version = Version("0");
+    version = base::Version("0");
 
   // |lower_bound| returns the latest version that is not newer than |version|.
-  std::map<Version, SecurityStatus, VersionComparator>::const_iterator it =
-      versions_.lower_bound(version);
+  std::map<base::Version, SecurityStatus, VersionComparator>::const_iterator

[brettw, 2015/08/13 18:24:35]

Can you just change this to auto it = versions_....

+      it = versions_.lower_bound(version);
   // If there is at least one version defined, everything older than the oldest
   // defined version is considered out-of-date.
   if (it == versions_.end())
     return SECURITY_STATUS_OUT_OF_DATE;
 
   return it->second;
 }
 
-bool PluginMetadata::VersionComparator::operator() (const Version& lhs,
-                                                    const Version& rhs) const {
+bool PluginMetadata::VersionComparator::operator()(
+    const base::Version& lhs,
+    const base::Version& rhs) const {
   // Keep versions ordered by newest (biggest) first.
   return lhs.CompareTo(rhs) > 0;
 }
 
 scoped_ptr<PluginMetadata> PluginMetadata::Clone() const {
   PluginMetadata* copy = new PluginMetadata(identifier_,
                                             name_,
                                             url_for_display_,
                                             plugin_url_,
                                             help_url_,
                                             group_name_matcher_,
                                             language_);
   copy->versions_ = versions_;
   return make_scoped_ptr(copy);
 }