Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 1281313003: base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more fixes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 3ed97062a3d71adc4ad5c3b407eeadce3cb98493..bdfb3333c476f00136ae57adb0b2b4007c6939ea 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -1563,7 +1563,7 @@ void ExtensionService::AddExtension(const Extension* extension) {
void ExtensionService::AddComponentExtension(const Extension* extension) {
const std::string old_version_string(
extension_prefs_->GetVersionString(extension->id()));
- const Version old_version(old_version_string);
+ const base::Version old_version(old_version_string);
VLOG(1) << "AddComponentExtension " << extension->name();
if (!old_version.IsValid() || !old_version.Equals(*extension->version())) {
@@ -2134,13 +2134,13 @@ const Extension* ExtensionService::GetInstalledExtension(
}
bool ExtensionService::OnExternalExtensionFileFound(
- const std::string& id,
- const Version* version,
- const base::FilePath& path,
- Manifest::Location location,
- int creation_flags,
- bool mark_acknowledged,
- bool install_immediately) {
+ const std::string& id,
+ const base::Version* version,
+ const base::FilePath& path,
+ Manifest::Location location,
+ int creation_flags,
+ bool mark_acknowledged,
+ bool install_immediately) {
CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
CHECK(crx_file::id_util::IdIsValid(id));
if (extension_prefs_->IsExternalExtensionUninstalled(id))
« no previous file with comments | « chrome/browser/extensions/extension_management_internal.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698