Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: components/variations/study_filtering_unittest.cc

Issue 1281313003: base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more fixes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/variations/processed_study.cc ('k') | content/browser/gpu/gpu_data_manager_impl_private.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/variations/study_filtering_unittest.cc
diff --git a/components/variations/study_filtering_unittest.cc b/components/variations/study_filtering_unittest.cc
index 29b7c93ed8936541d8a13bad773d68f1f24943ea..0c6c3786c9bfe0d0c0d33391a63e66c7393edfc4 100644
--- a/components/variations/study_filtering_unittest.cc
+++ b/components/variations/study_filtering_unittest.cc
@@ -275,8 +275,8 @@ TEST(VariationsStudyFilteringTest, CheckStudyVersion) {
for (size_t i = 0; i < arraysize(min_test_cases); ++i) {
filter.set_min_version(min_test_cases[i].min_version);
- const bool result =
- internal::CheckStudyVersion(filter, Version(min_test_cases[i].version));
+ const bool result = internal::CheckStudyVersion(
+ filter, base::Version(min_test_cases[i].version));
EXPECT_EQ(min_test_cases[i].expected_result, result) <<
"Min. version case " << i << " failed!";
}
@@ -284,8 +284,8 @@ TEST(VariationsStudyFilteringTest, CheckStudyVersion) {
for (size_t i = 0; i < arraysize(max_test_cases); ++i) {
filter.set_max_version(max_test_cases[i].max_version);
- const bool result =
- internal::CheckStudyVersion(filter, Version(max_test_cases[i].version));
+ const bool result = internal::CheckStudyVersion(
+ filter, base::Version(max_test_cases[i].version));
EXPECT_EQ(max_test_cases[i].expected_result, result) <<
"Max version case " << i << " failed!";
}
@@ -297,16 +297,14 @@ TEST(VariationsStudyFilteringTest, CheckStudyVersion) {
filter.set_max_version(max_test_cases[j].max_version);
if (!min_test_cases[i].expected_result) {
- const bool result =
- internal::CheckStudyVersion(
- filter, Version(min_test_cases[i].version));
+ const bool result = internal::CheckStudyVersion(
+ filter, base::Version(min_test_cases[i].version));
EXPECT_FALSE(result) << "Case " << i << "," << j << " failed!";
}
if (!max_test_cases[j].expected_result) {
- const bool result =
- internal::CheckStudyVersion(
- filter, Version(max_test_cases[j].version));
+ const bool result = internal::CheckStudyVersion(
+ filter, base::Version(max_test_cases[j].version));
EXPECT_FALSE(result) << "Case " << i << "," << j << " failed!";
}
}
« no previous file with comments | « components/variations/processed_study.cc ('k') | content/browser/gpu/gpu_data_manager_impl_private.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698