chrome/app/chrome_crash_reporter_client.cc - Issue 1281313003: base: Remove using:: declaration from version.h header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/chrome_crash_reporter_client.cc

Issue 1281313003: base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more fixes Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/chrome_crash_reporter_client.cc

diff --git a/chrome/app/chrome_crash_reporter_client.cc b/chrome/app/chrome_crash_reporter_client.cc

index 95ee24ff8f8536195c0846c68e2bafb3d1f8cabd..74567d2ebc5e7a695048273f39cfb1a380bdadbe 100644

--- a/chrome/app/chrome_crash_reporter_client.cc

+++ b/chrome/app/chrome_crash_reporter_client.cc

@@ -159,7 +159,7 @@ bool ChromeCrashReporterClient::AboutToRestart() {

bool ChromeCrashReporterClient::GetDeferredUploadsSupported(

bool is_per_user_install) {

- Version update_version = GoogleUpdateSettings::GetGoogleUpdateVersion(

+ base::Version update_version = GoogleUpdateSettings::GetGoogleUpdateVersion(

!is_per_user_install);

if (!update_version.IsValid() ||

update_version.IsOlderThan(std::string(kMinUpdateVersion)))

« no previous file with comments | « base/version_unittest.cc ('k') | chrome/app/client_util.cc » ('j') | no next file with comments »