Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Side by Side Diff: components/variations/study_filtering_unittest.cc

Issue 1281313003: base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more fixes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/variations/study_filtering.h" 5 #include "components/variations/study_filtering.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/strings/string_split.h" 9 #include "base/strings/string_split.h"
10 #include "components/variations/processed_study.h" 10 #include "components/variations/processed_study.h"
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 { "1.*", "2.3.4", false }, 268 { "1.*", "2.3.4", false },
269 }; 269 };
270 270
271 Study_Filter filter; 271 Study_Filter filter;
272 272
273 // Min/max version not set should result in true. 273 // Min/max version not set should result in true.
274 EXPECT_TRUE(internal::CheckStudyVersion(filter, base::Version("1.2.3"))); 274 EXPECT_TRUE(internal::CheckStudyVersion(filter, base::Version("1.2.3")));
275 275
276 for (size_t i = 0; i < arraysize(min_test_cases); ++i) { 276 for (size_t i = 0; i < arraysize(min_test_cases); ++i) {
277 filter.set_min_version(min_test_cases[i].min_version); 277 filter.set_min_version(min_test_cases[i].min_version);
278 const bool result = 278 const bool result = internal::CheckStudyVersion(
279 internal::CheckStudyVersion(filter, Version(min_test_cases[i].version)); 279 filter, base::Version(min_test_cases[i].version));
280 EXPECT_EQ(min_test_cases[i].expected_result, result) << 280 EXPECT_EQ(min_test_cases[i].expected_result, result) <<
281 "Min. version case " << i << " failed!"; 281 "Min. version case " << i << " failed!";
282 } 282 }
283 filter.clear_min_version(); 283 filter.clear_min_version();
284 284
285 for (size_t i = 0; i < arraysize(max_test_cases); ++i) { 285 for (size_t i = 0; i < arraysize(max_test_cases); ++i) {
286 filter.set_max_version(max_test_cases[i].max_version); 286 filter.set_max_version(max_test_cases[i].max_version);
287 const bool result = 287 const bool result = internal::CheckStudyVersion(
288 internal::CheckStudyVersion(filter, Version(max_test_cases[i].version)); 288 filter, base::Version(max_test_cases[i].version));
289 EXPECT_EQ(max_test_cases[i].expected_result, result) << 289 EXPECT_EQ(max_test_cases[i].expected_result, result) <<
290 "Max version case " << i << " failed!"; 290 "Max version case " << i << " failed!";
291 } 291 }
292 292
293 // Check intersection semantics. 293 // Check intersection semantics.
294 for (size_t i = 0; i < arraysize(min_test_cases); ++i) { 294 for (size_t i = 0; i < arraysize(min_test_cases); ++i) {
295 for (size_t j = 0; j < arraysize(max_test_cases); ++j) { 295 for (size_t j = 0; j < arraysize(max_test_cases); ++j) {
296 filter.set_min_version(min_test_cases[i].min_version); 296 filter.set_min_version(min_test_cases[i].min_version);
297 filter.set_max_version(max_test_cases[j].max_version); 297 filter.set_max_version(max_test_cases[j].max_version);
298 298
299 if (!min_test_cases[i].expected_result) { 299 if (!min_test_cases[i].expected_result) {
300 const bool result = 300 const bool result = internal::CheckStudyVersion(
301 internal::CheckStudyVersion( 301 filter, base::Version(min_test_cases[i].version));
302 filter, Version(min_test_cases[i].version));
303 EXPECT_FALSE(result) << "Case " << i << "," << j << " failed!"; 302 EXPECT_FALSE(result) << "Case " << i << "," << j << " failed!";
304 } 303 }
305 304
306 if (!max_test_cases[j].expected_result) { 305 if (!max_test_cases[j].expected_result) {
307 const bool result = 306 const bool result = internal::CheckStudyVersion(
308 internal::CheckStudyVersion( 307 filter, base::Version(max_test_cases[j].version));
309 filter, Version(max_test_cases[j].version));
310 EXPECT_FALSE(result) << "Case " << i << "," << j << " failed!"; 308 EXPECT_FALSE(result) << "Case " << i << "," << j << " failed!";
311 } 309 }
312 } 310 }
313 } 311 }
314 } 312 }
315 313
316 TEST(VariationsStudyFilteringTest, CheckStudyHardwareClass) { 314 TEST(VariationsStudyFilteringTest, CheckStudyHardwareClass) {
317 struct { 315 struct {
318 const char* hardware_class; 316 const char* hardware_class;
319 const char* exclude_hardware_class; 317 const char* exclude_hardware_class;
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
568 566
569 default_group->set_name("def"); 567 default_group->set_name("def");
570 EXPECT_TRUE(processed_study.Init(&study, false)); 568 EXPECT_TRUE(processed_study.Init(&study, false));
571 Study_Experiment* repeated_group = study.add_experiment(); 569 Study_Experiment* repeated_group = study.add_experiment();
572 repeated_group->set_name("abc"); 570 repeated_group->set_name("abc");
573 repeated_group->set_probability_weight(1); 571 repeated_group->set_probability_weight(1);
574 EXPECT_FALSE(processed_study.Init(&study, false)); 572 EXPECT_FALSE(processed_study.Init(&study, false));
575 } 573 }
576 574
577 } // namespace variations 575 } // namespace variations
OLDNEW
« no previous file with comments | « components/variations/processed_study.cc ('k') | content/browser/gpu/gpu_data_manager_impl_private.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698