Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1261643004: Some cleanup in GrTextureProvider and GrResourceProvider (Closed)

Created:
5 years, 4 months ago by bsalomon
Modified:
5 years, 2 months ago
CC:
review_skia.org
Base URL:
https://skia.googlesource.com/skia.git@pathargs
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Some cleanup in GrTextureProvider and GrResourceProvider. Committed: https://skia.googlesource.com/skia/+/eae6200acbec2255ac00ab363ffbe16758ec9076

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : update #

Total comments: 1

Patch Set 4 : Address comment #

Patch Set 5 : fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -147 lines) Patch
M include/gpu/GrTextureProvider.h View 1 2 2 chunks +25 lines, -31 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrBatchFontCache.cpp View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/GrBlurUtils.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/GrBufferAllocPool.cpp View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M src/gpu/GrClipMaskCache.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +9 lines, -7 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrIndexBuffer.h View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrResourceProvider.h View 1 2 3 chunks +34 lines, -10 lines 0 comments Download
M src/gpu/GrResourceProvider.cpp View 1 2 3 4 4 chunks +17 lines, -13 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrTextureProvider.cpp View 1 2 3 5 chunks +13 lines, -16 lines 1 comment Download
M src/gpu/GrVertexBuffer.h View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M tests/GLProgramsTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/TessellatingPathRendererTests.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bsalomon
5 years, 4 months ago (2015-07-31 15:28:50 UTC) #2
bsalomon
On 2015/07/31 15:28:50, bsalomon wrote: The meat is in GrTP and GrRP, the rest is ...
5 years, 4 months ago (2015-07-31 15:29:30 UTC) #3
robertphillips
lgtm + a question https://codereview.chromium.org/1261643004/diff/40001/src/gpu/GrTextureProvider.cpp File src/gpu/GrTextureProvider.cpp (right): https://codereview.chromium.org/1261643004/diff/40001/src/gpu/GrTextureProvider.cpp#newcode58 src/gpu/GrTextureProvider.cpp:58: } else { Don't we ...
5 years, 4 months ago (2015-07-31 16:51:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261643004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261643004/80001
5 years, 4 months ago (2015-07-31 20:52:04 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/eae6200acbec2255ac00ab363ffbe16758ec9076
5 years, 4 months ago (2015-07-31 20:59:34 UTC) #8
brucedawson
5 years, 4 months ago (2015-08-05 17:41:19 UTC) #10
Message was sent while issue was closed. 
This change introduced a bug due to variable shadowing.

https://codereview.chromium.org/1261643004/diff/80001/src/gpu/GrTextureProvid...
File src/gpu/GrTextureProvider.cpp (right):

https://codereview.chromium.org/1261643004/diff/80001/src/gpu/GrTextureProvid...
src/gpu/GrTextureProvider.cpp:82: if (kNoPendingIO_ScratchTextureFlag &
scratchFlags) {
This use of scratchFlags now refers to the local variable declared on the line
above, which is incorrect. The parameter should be renamed, perhaps back to
'flags'.

Currently the 'if' block will always be skipped.

I opened bug https://code.google.com/p/skia/issues/detail?id=4169 to track this.

Powered by Google App Engine
This is Rietveld 408576698