src/effects/SkXfermodeImageFilter.cpp - Issue 1261643004: Some cleanup in GrTextureProvider and GrResourceProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkXfermodeImageFilter.cpp

Issue 1261643004: Some cleanup in GrTextureProvider and GrResourceProvider (Closed) Base URL: https://skia.googlesource.com/skia.git@pathargs

Patch Set: fix Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkXfermodeImageFilter.cpp

diff --git a/src/effects/SkXfermodeImageFilter.cpp b/src/effects/SkXfermodeImageFilter.cpp

index b45a4225d17101a14c43b236752a4416c2051e60..dc61b4e76ec5817bca9d66a22fe6be884cb7e2cb 100644

--- a/src/effects/SkXfermodeImageFilter.cpp

+++ b/src/effects/SkXfermodeImageFilter.cpp

@@ -160,8 +160,7 @@ bool SkXfermodeImageFilter::filterImageGPU(Proxy* proxy,

desc.fWidth = src.width();

desc.fHeight = src.height();

desc.fConfig = kSkia8888_GrPixelConfig;

- SkAutoTUnref<GrTexture> dst(context->textureProvider()->refScratchTexture(

- desc, GrTextureProvider::kApprox_ScratchTexMatch));

+ SkAutoTUnref<GrTexture> dst(context->textureProvider()->createApproxTexture(desc));

if (!dst) {

return false;

}