src/effects/SkLightingImageFilter.cpp - Issue 1261643004: Some cleanup in GrTextureProvider and GrResourceProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkLightingImageFilter.cpp

Issue 1261643004: Some cleanup in GrTextureProvider and GrResourceProvider (Closed) Base URL: https://skia.googlesource.com/skia.git@pathargs

Patch Set: fix Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkLightingImageFilter.cpp

diff --git a/src/effects/SkLightingImageFilter.cpp b/src/effects/SkLightingImageFilter.cpp

index a30955faf7f7a1561549eabe415b6b1d34bc14be..898b094a6bc1cadeba746152d47e19db0bb89615 100644

--- a/src/effects/SkLightingImageFilter.cpp

+++ b/src/effects/SkLightingImageFilter.cpp

@@ -382,8 +382,7 @@ bool SkLightingImageFilterInternal::filterImageGPU(Proxy* proxy,

desc.fHeight = bounds.height();

desc.fConfig = kRGBA_8888_GrPixelConfig;

- SkAutoTUnref<GrTexture> dst(context->textureProvider()->refScratchTexture(desc,

- GrTextureProvider::kApprox_ScratchTexMatch));

+ SkAutoTUnref<GrTexture> dst(context->textureProvider()->createApproxTexture(desc));

if (!dst) {

return false;

}