Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1258093002: FX Bool considered harmful, part 3 (Closed)

Created:
5 years, 4 months ago by Tom Sepez
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

FX Bool considered harmful, part 3 Try to reland this patch after fixing underlying issues that caused it to be reverted. fx_system.h is the only manual edit. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ff46aaf499edcf153ee2f57c7016587aa96dcfa0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9800 lines, -9809 lines) Patch
M core/include/fdrm/fx_crypt.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/include/fpdfapi/fpdf_module.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/include/fpdfapi/fpdf_objects.h View 21 chunks +36 lines, -36 lines 0 comments Download
M core/include/fpdfapi/fpdf_page.h View 6 chunks +13 lines, -13 lines 0 comments Download
M core/include/fpdfapi/fpdf_pageobj.h View 9 chunks +14 lines, -14 lines 0 comments Download
M core/include/fpdfapi/fpdf_parser.h View 36 chunks +100 lines, -100 lines 0 comments Download
M core/include/fpdfapi/fpdf_render.h View 8 chunks +14 lines, -14 lines 0 comments Download
M core/include/fpdfapi/fpdf_resource.h View 33 chunks +71 lines, -71 lines 0 comments Download
M core/include/fpdfapi/fpdf_serial.h View 3 chunks +14 lines, -14 lines 0 comments Download
M core/include/fpdfdoc/fpdf_ap.h View 2 chunks +6 lines, -6 lines 0 comments Download
M core/include/fpdfdoc/fpdf_doc.h View 39 chunks +85 lines, -85 lines 0 comments Download
M core/include/fpdfdoc/fpdf_tagged.h View 1 chunk +5 lines, -5 lines 0 comments Download
M core/include/fpdfdoc/fpdf_vt.h View 7 chunks +24 lines, -24 lines 0 comments Download
M core/include/fpdftext/fpdf_text.h View 5 chunks +13 lines, -13 lines 0 comments Download
M core/include/fxcodec/fx_codec.h View 10 chunks +20 lines, -20 lines 0 comments Download
M core/include/fxcodec/fx_codec_provider.h View 2 chunks +6 lines, -6 lines 0 comments Download
M core/include/fxcrt/fx_arb.h View 1 chunk +3 lines, -3 lines 0 comments Download
M core/include/fxcrt/fx_basic.h View 27 chunks +59 lines, -59 lines 0 comments Download
M core/include/fxcrt/fx_coordinates.h View 12 chunks +35 lines, -35 lines 0 comments Download
M core/include/fxcrt/fx_ext.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/include/fxcrt/fx_stream.h View 8 chunks +33 lines, -33 lines 0 comments Download
M core/include/fxcrt/fx_string.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/include/fxcrt/fx_system.h View 2 chunks +0 lines, -9 lines 0 comments Download
M core/include/fxcrt/fx_ucd.h View 1 chunk +6 lines, -6 lines 0 comments Download
M core/include/fxcrt/fx_xml.h View 8 chunks +15 lines, -15 lines 0 comments Download
M core/include/fxge/fpf.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/include/fxge/fx_dib.h View 19 chunks +59 lines, -59 lines 0 comments Download
M core/include/fxge/fx_font.h View 16 chunks +39 lines, -39 lines 0 comments Download
M core/include/fxge/fx_ge.h View 16 chunks +69 lines, -69 lines 0 comments Download
M core/include/fxge/fx_ge_apple.h View 1 chunk +4 lines, -4 lines 0 comments Download
M core/include/fxge/fx_ge_win32.h View 1 chunk +3 lines, -3 lines 0 comments Download
M core/include/thirdparties/libjpeg/jmorecfg.h View 2 chunks +5 lines, -5 lines 0 comments Download
M core/include/thirdparties/libjpeg/jpegint.h View 3 chunks +3 lines, -3 lines 0 comments Download
M core/include/thirdparties/libjpeg/jpeglib.h View 8 chunks +26 lines, -26 lines 0 comments Download
M core/src/fdrm/crypto/fx_crypt.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fdrm/crypto/fx_crypt_aes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fdrm/crypto/fx_crypt_sha.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_basic_module.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/editint.h View 3 chunks +7 lines, -7 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 46 chunks +122 lines, -122 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 17 chunks +19 lines, -19 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp View 9 chunks +12 lines, -12 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/font_int.h View 6 chunks +17 lines, -17 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 38 chunks +76 lines, -76 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 33 chunks +69 lines, -69 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/ttgsubtable.h View 3 chunks +5 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/ttgsubtable.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page.cpp View 12 chunks +15 lines, -15 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 38 chunks +158 lines, -158 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 11 chunks +14 lines, -14 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp View 30 chunks +69 lines, -69 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp View 11 chunks +22 lines, -22 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 32 chunks +49 lines, -49 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 28 chunks +39 lines, -39 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp View 10 chunks +25 lines, -25 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/pageint.h View 17 chunks +35 lines, -35 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/filters_int.h View 4 chunks +7 lines, -7 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp View 12 chunks +25 lines, -25 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp View 6 chunks +15 lines, -15 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp View 34 chunks +105 lines, -105 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_filters.cpp View 14 chunks +30 lines, -30 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 27 chunks +56 lines, -56 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 127 chunks +528 lines, -528 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp View 7 chunks +19 lines, -19 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render.cpp View 47 chunks +82 lines, -82 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_cache.cpp View 11 chunks +19 lines, -19 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp View 37 chunks +93 lines, -93 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 29 chunks +90 lines, -90 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 16 chunks +32 lines, -32 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp View 20 chunks +55 lines, -55 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/render_int.h View 17 chunks +81 lines, -81 lines 0 comments Download
M core/src/fpdfdoc/doc_action.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfdoc/doc_annot.cpp View 5 chunks +16 lines, -16 lines 0 comments Download
M core/src/fpdfdoc/doc_ap.cpp View 27 chunks +48 lines, -48 lines 0 comments Download
M core/src/fpdfdoc/doc_basic.cpp View 6 chunks +10 lines, -10 lines 0 comments Download
M core/src/fpdfdoc/doc_form.cpp View 43 chunks +82 lines, -82 lines 0 comments Download
M core/src/fpdfdoc/doc_formcontrol.cpp View 5 chunks +18 lines, -18 lines 0 comments Download
M core/src/fpdfdoc/doc_formfield.cpp View 34 chunks +100 lines, -100 lines 0 comments Download
M core/src/fpdfdoc/doc_metadata.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_ocg.cpp View 9 chunks +36 lines, -36 lines 0 comments Download
M core/src/fpdfdoc/doc_tagged.cpp View 12 chunks +18 lines, -18 lines 0 comments Download
M core/src/fpdfdoc/doc_utils.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/src/fpdfdoc/doc_utils.cpp View 10 chunks +27 lines, -27 lines 0 comments Download
M core/src/fpdfdoc/doc_viewerPreferences.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M core/src/fpdfdoc/doc_vt.cpp View 37 chunks +145 lines, -145 lines 0 comments Download
M core/src/fpdfdoc/pdf_vt.h View 12 chunks +36 lines, -36 lines 0 comments Download
M core/src/fpdfdoc/tagged_int.h View 2 chunks +7 lines, -7 lines 0 comments Download
M core/src/fpdftext/fpdf_text.cpp View 16 chunks +25 lines, -25 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 71 chunks +176 lines, -176 lines 0 comments Download
M core/src/fpdftext/fpdf_text_search.cpp View 7 chunks +23 lines, -23 lines 0 comments Download
M core/src/fpdftext/text_int.h View 9 chunks +30 lines, -30 lines 0 comments Download
M core/src/fpdftext/txtproc.h View 2 chunks +5 lines, -5 lines 0 comments Download
M core/src/fxcodec/codec/codec_int.h View 9 chunks +21 lines, -21 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec.cpp View 12 chunks +29 lines, -29 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_fax.cpp View 16 chunks +43 lines, -43 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_flate.cpp View 20 chunks +27 lines, -27 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_icc.cpp View 4 chunks +15 lines, -15 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jbig.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpeg.cpp View 19 chunks +54 lines, -54 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpx_opj.cpp View 10 chunks +22 lines, -22 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_BitStream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Context.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Context.cpp View 8 chunks +15 lines, -15 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_GeneralDecoder.h View 11 chunks +20 lines, -20 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_GeneralDecoder.cpp View 49 chunks +57 lines, -57 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_HuffmanTable.h View 2 chunks +5 lines, -5 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_HuffmanTable.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_HuffmanTable_Standard.h View 15 chunks +15 lines, -15 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Image.h View 2 chunks +13 lines, -13 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Image.cpp View 15 chunks +30 lines, -30 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Page.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_SymbolDict.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_SymbolDict.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/extension.h View 19 chunks +56 lines, -56 lines 0 comments Download
M core/src/fxcrt/fx_arabic.h View 1 chunk +4 lines, -4 lines 0 comments Download
M core/src/fxcrt/fx_arabic.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M core/src/fxcrt/fx_basic_array.cpp View 7 chunks +22 lines, -22 lines 0 comments Download
M core/src/fxcrt/fx_basic_bstring.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcrt/fx_basic_buffer.cpp View 5 chunks +24 lines, -24 lines 0 comments Download
M core/src/fxcrt/fx_basic_coords.cpp View 7 chunks +18 lines, -18 lines 0 comments Download
M core/src/fxcrt/fx_basic_gcc.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcrt/fx_basic_maps.cpp View 10 chunks +26 lines, -26 lines 0 comments Download
M core/src/fxcrt/fx_basic_util.cpp View 9 chunks +40 lines, -40 lines 0 comments Download
M core/src/fxcrt/fx_basic_wstring.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcrt/fx_extension.cpp View 8 chunks +14 lines, -14 lines 0 comments Download
M core/src/fxcrt/fx_unicode.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M core/src/fxcrt/fx_xml_parser.cpp View 15 chunks +51 lines, -51 lines 0 comments Download
M core/src/fxcrt/fxcrt_platforms.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/src/fxcrt/fxcrt_platforms.cpp View 3 chunks +20 lines, -20 lines 0 comments Download
M core/src/fxcrt/fxcrt_posix.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/src/fxcrt/fxcrt_posix.cpp View 3 chunks +19 lines, -19 lines 0 comments Download
M core/src/fxcrt/fxcrt_windows.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/src/fxcrt/fxcrt_windows.cpp View 4 chunks +20 lines, -20 lines 0 comments Download
M core/src/fxcrt/xml_int.h View 6 chunks +19 lines, -19 lines 0 comments Download
M core/src/fxge/agg/include/fx_agg_driver.h View 4 chunks +19 lines, -19 lines 0 comments Download
M core/src/fxge/agg/src/fx_agg_driver.cpp View 35 chunks +82 lines, -82 lines 0 comments Download
M core/src/fxge/android/fpf_skiafont.h View 1 chunk +3 lines, -3 lines 0 comments Download
M core/src/fxge/android/fpf_skiafont.cpp View 4 chunks +15 lines, -15 lines 0 comments Download
M core/src/fxge/android/fpf_skiafontmgr.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fxge/android/fpf_skiafontmgr.cpp View 10 chunks +14 lines, -14 lines 0 comments Download
M core/src/fxge/android/fx_android_font.h View 1 chunk +5 lines, -5 lines 0 comments Download
M core/src/fxge/android/fx_android_font.cpp View 2 chunks +12 lines, -12 lines 0 comments Download
M core/src/fxge/apple/apple_int.h View 5 chunks +25 lines, -25 lines 0 comments Download
M core/src/fxge/apple/fx_apple_platform.cpp View 7 chunks +13 lines, -13 lines 0 comments Download
M core/src/fxge/apple/fx_mac_imp.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M core/src/fxge/apple/fx_quartz_device.cpp View 32 chunks +73 lines, -73 lines 0 comments Download
M core/src/fxge/dib/dib_int.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/src/fxge/dib/fx_dib_composite.cpp View 47 chunks +71 lines, -71 lines 0 comments Download
M core/src/fxge/dib/fx_dib_convert.cpp View 33 chunks +58 lines, -58 lines 0 comments Download
M core/src/fxge/dib/fx_dib_engine.cpp View 11 chunks +36 lines, -36 lines 0 comments Download
M core/src/fxge/dib/fx_dib_main.cpp View 52 chunks +123 lines, -123 lines 0 comments Download
M core/src/fxge/dib/fx_dib_transform.cpp View 11 chunks +16 lines, -16 lines 0 comments Download
M core/src/fxge/ge/fx_ge_device.cpp View 16 chunks +47 lines, -47 lines 0 comments Download
M core/src/fxge/ge/fx_ge_font.cpp View 13 chunks +36 lines, -36 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 30 chunks +60 lines, -60 lines 0 comments Download
M core/src/fxge/ge/fx_ge_linux.cpp View 7 chunks +10 lines, -10 lines 0 comments Download
M core/src/fxge/ge/fx_ge_path.cpp View 11 chunks +34 lines, -34 lines 0 comments Download
M core/src/fxge/ge/fx_ge_ps.cpp View 21 chunks +32 lines, -32 lines 0 comments Download
M core/src/fxge/ge/fx_ge_text.cpp View 27 chunks +47 lines, -47 lines 0 comments Download
M core/src/fxge/ge/text_int.h View 3 chunks +6 lines, -6 lines 0 comments Download
M core/src/fxge/skia/fx_skia_blitter_new.h View 3 chunks +4 lines, -4 lines 0 comments Download
M core/src/fxge/skia/fx_skia_blitter_new.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M core/src/fxge/skia/fx_skia_device.h View 3 chunks +19 lines, -19 lines 0 comments Download
M core/src/fxge/skia/fx_skia_device.cpp View 16 chunks +51 lines, -51 lines 0 comments Download
M core/src/fxge/win32/dwrite_int.h View 1 chunk +3 lines, -3 lines 0 comments Download
M core/src/fxge/win32/fx_win32_device.cpp View 35 chunks +99 lines, -99 lines 0 comments Download
M core/src/fxge/win32/fx_win32_dib.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M core/src/fxge/win32/fx_win32_dwrite.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M core/src/fxge/win32/fx_win32_gdipext.cpp View 20 chunks +45 lines, -45 lines 0 comments Download
M core/src/fxge/win32/fx_win32_print.cpp View 12 chunks +43 lines, -43 lines 0 comments Download
M core/src/fxge/win32/win32_int.h View 10 chunks +47 lines, -47 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_CheckBox.h View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_ComboBox.h View 2 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_FormFiller.h View 6 chunks +28 lines, -28 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_IFormFiller.h View 3 chunks +26 lines, -26 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_ListBox.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_Notify.h View 1 chunk +23 lines, -23 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_PushButton.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/formfiller/FFL_RadioButton.h View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_TextField.h View 2 chunks +7 lines, -7 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_Utils.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_actionhandler.h View 2 chunks +24 lines, -24 lines 0 comments Download
M fpdfsdk/include/fsdk_annothandler.h View 10 chunks +50 lines, -50 lines 0 comments Download
M fpdfsdk/include/fsdk_baseannot.h View 5 chunks +14 lines, -14 lines 0 comments Download
M fpdfsdk/include/fsdk_baseform.h View 11 chunks +53 lines, -53 lines 0 comments Download
M fpdfsdk/include/fsdk_define.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 10 chunks +44 lines, -44 lines 0 comments Download
M fpdfsdk/include/fsdk_rendercontext.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fx_systemhandler.h View 2 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/include/fxedit/fx_edit.h View 10 chunks +82 lines, -82 lines 0 comments Download
M fpdfsdk/include/fxedit/fxet_edit.h View 14 chunks +112 lines, -112 lines 0 comments Download
M fpdfsdk/include/fxedit/fxet_list.h View 10 chunks +32 lines, -32 lines 0 comments Download
M fpdfsdk/include/javascript/Document.h View 4 chunks +81 lines, -81 lines 0 comments Download
M fpdfsdk/include/javascript/Field.h View 5 chunks +86 lines, -86 lines 0 comments Download
M fpdfsdk/include/javascript/IJavaScript.h View 5 chunks +29 lines, -29 lines 0 comments Download
M fpdfsdk/include/javascript/Icon.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/javascript/JS_Context.h View 4 chunks +31 lines, -31 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Define.h View 5 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/include/javascript/JS_EventHandler.h View 4 chunks +40 lines, -40 lines 0 comments Download
M fpdfsdk/include/javascript/JS_GlobalData.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Object.h View 4 chunks +7 lines, -7 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Runtime.h View 2 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Value.h View 5 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/include/javascript/PublicMethods.h View 3 chunks +34 lines, -34 lines 0 comments Download
M fpdfsdk/include/javascript/app.h View 1 chunk +35 lines, -35 lines 0 comments Download
M fpdfsdk/include/javascript/color.h View 1 chunk +14 lines, -14 lines 0 comments Download
M fpdfsdk/include/javascript/console.h View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/event.h View 1 chunk +20 lines, -20 lines 0 comments Download
M fpdfsdk/include/javascript/global.h View 4 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/include/javascript/report.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/javascript/util.h View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Button.h View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Caret.h View 3 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ComboBox.h View 6 chunks +11 lines, -11 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Edit.h View 5 chunks +26 lines, -26 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_EditCtrl.h View 6 chunks +15 lines, -15 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_FontMap.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Icon.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_IconList.h View 5 chunks +14 lines, -14 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ListBox.h View 5 chunks +13 lines, -13 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ListCtrl.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Note.h View 14 chunks +32 lines, -32 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ScrollBar.h View 6 chunks +13 lines, -13 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Signature.h View 2 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_SpecialButton.h View 2 chunks +10 lines, -10 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Utils.h View 5 chunks +7 lines, -7 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Wnd.h View 12 chunks +41 lines, -41 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_CBA_Fontmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/formfiller/FFL_CheckBox.cpp View 4 chunks +19 lines, -19 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_ComboBox.cpp View 15 chunks +33 lines, -33 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_FormFiller.cpp View 16 chunks +95 lines, -95 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_IFormFiller.cpp View 40 chunks +124 lines, -124 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_ListBox.cpp View 11 chunks +20 lines, -20 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_Notify.cpp View 3 chunks +45 lines, -45 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_PushButton.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/formfiller/FFL_RadioButton.cpp View 3 chunks +21 lines, -21 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_TextField.cpp View 13 chunks +29 lines, -29 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_Utils.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/fpdf_dataavail.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdf_ext.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M fpdfsdk/src/fpdf_flatten.cpp View 7 chunks +12 lines, -12 lines 0 comments Download
M fpdfsdk/src/fpdf_progressive.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/fpdf_sysfontinfo.cpp View 2 chunks +11 lines, -11 lines 0 comments Download
M fpdfsdk/src/fpdf_transformpage.cpp View 7 chunks +14 lines, -14 lines 0 comments Download
M fpdfsdk/src/fpdfdoc.cpp View 4 chunks +11 lines, -11 lines 0 comments Download
M fpdfsdk/src/fpdfeditimg.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M fpdfsdk/src/fpdfeditpage.cpp View 3 chunks +11 lines, -11 lines 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 13 chunks +15 lines, -15 lines 0 comments Download
M fpdfsdk/src/fpdfppo.cpp View 17 chunks +32 lines, -32 lines 0 comments Download
M fpdfsdk/src/fpdfsave.cpp View 4 chunks +11 lines, -11 lines 0 comments Download
M fpdfsdk/src/fpdftext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 12 chunks +27 lines, -27 lines 0 comments Download
M fpdfsdk/src/fsdk_actionhandler.cpp View 26 chunks +68 lines, -68 lines 0 comments Download
M fpdfsdk/src/fsdk_annothandler.cpp View 34 chunks +69 lines, -69 lines 0 comments Download
M fpdfsdk/src/fsdk_baseannot.cpp View 17 chunks +38 lines, -38 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 62 chunks +124 lines, -124 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 33 chunks +83 lines, -83 lines 0 comments Download
M fpdfsdk/src/fsdk_rendercontext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_ap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fxedit/fxet_edit.cpp View 96 chunks +234 lines, -234 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_list.cpp View 26 chunks +53 lines, -53 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_pageobjs.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 47 chunks +237 lines, -237 lines 0 comments Download
M fpdfsdk/src/javascript/Field.cpp View 174 chunks +440 lines, -440 lines 0 comments Download
M fpdfsdk/src/javascript/Icon.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Context.cpp View 7 chunks +32 lines, -32 lines 0 comments Download
M fpdfsdk/src/javascript/JS_EventHandler.cpp View 28 chunks +51 lines, -51 lines 0 comments Download
M fpdfsdk/src/javascript/JS_GlobalData.cpp View 7 chunks +12 lines, -12 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 9 chunks +34 lines, -34 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Value.cpp View 4 chunks +17 lines, -17 lines 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 68 chunks +188 lines, -188 lines 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 21 chunks +89 lines, -89 lines 0 comments Download
M fpdfsdk/src/javascript/color.cpp View 5 chunks +12 lines, -12 lines 0 comments Download
M fpdfsdk/src/javascript/console.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
M fpdfsdk/src/javascript/event.cpp View 24 chunks +70 lines, -70 lines 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 10 chunks +34 lines, -34 lines 0 comments Download
M fpdfsdk/src/javascript/report.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/util.cpp View 12 chunks +23 lines, -23 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Button.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Caret.cpp View 5 chunks +11 lines, -11 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ComboBox.cpp View 16 chunks +50 lines, -50 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Edit.cpp View 36 chunks +114 lines, -114 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_EditCtrl.cpp View 18 chunks +54 lines, -54 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_FontMap.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Icon.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_IconList.cpp View 18 chunks +30 lines, -30 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Label.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ListBox.cpp View 12 chunks +40 lines, -40 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ListCtrl.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Note.cpp View 47 chunks +97 lines, -97 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ScrollBar.cpp View 24 chunks +47 lines, -47 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Signature.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_SpecialButton.cpp View 3 chunks +18 lines, -18 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Utils.cpp View 42 chunks +52 lines, -52 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Wnd.cpp View 20 chunks +47 lines, -47 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
Lei, for OWNERS stamp, etc. Try try again.
5 years, 4 months ago (2015-07-27 16:19:23 UTC) #1
Lei Zhang
lgtm
5 years, 4 months ago (2015-07-27 18:44:22 UTC) #2
Tom Sepez
5 years, 4 months ago (2015-07-27 18:55:35 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ff46aaf499edcf153ee2f57c7016587aa96dcfa0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698