FX Bool considered harmful, part 3

core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fpdfapi/fpdf_page.h"
 #include "../../../include/fpdfapi/fpdf_serial.h"
 #include "../../../include/fpdfapi/fpdf_module.h"
 #include "../fpdf_page/pageint.h"
@@ skipping 10 matching lines @@
         m_pDocument = m_pPage->m_pDocument;
     }
     FX_POSITION pos = pPage->GetFirstObjectPosition();
     while (pos) {
         InsertPageObject(pPage->GetNextObject(pos));
     }
 }
 CPDF_PageContentGenerate::~CPDF_PageContentGenerate()
 {
 }
-FX_BOOL CPDF_PageContentGenerate::InsertPageObject(CPDF_PageObject* pPageObject)
+bool CPDF_PageContentGenerate::InsertPageObject(CPDF_PageObject* pPageObject)
 {
     if (!pPageObject) {
-        return FALSE;
+        return false;
     }
     return m_pageObjects.Add(pPageObject);
 }
 void CPDF_PageContentGenerate::GenerateContent()
 {
     CFX_ByteTextBuf buf;
     CPDF_Dictionary* pPageDict = m_pPage->m_pFormDict;
     for (int i = 0; i < m_pageObjects.GetSize(); ++i) {
         CPDF_PageObject* pPageObj = (CPDF_PageObject*)m_pageObjects[i];
         if (!pPageObj || pPageObj->m_Type != PDFPAGE_IMAGE) {
             continue;
         }
         ProcessImage(buf, (CPDF_ImageObject*)pPageObj);
     }
     CPDF_Object* pContent = pPageDict ? pPageDict->GetElementValue("Contents") : NULL;
     if (pContent != NULL) {
         pPageDict->RemoveAt("Contents");
     }
     CPDF_Stream* pStream = new CPDF_Stream(NULL, 0, NULL);
-    pStream->SetData(buf.GetBuffer(), buf.GetLength(), FALSE, FALSE);
+    pStream->SetData(buf.GetBuffer(), buf.GetLength(), false, false);
     m_pDocument->AddIndirectObject(pStream);
     pPageDict->SetAtReference("Contents", m_pDocument, pStream->GetObjNum());
 }
 CFX_ByteString CPDF_PageContentGenerate::RealizeResource(CPDF_Object* pResourceObj, const FX_CHAR* szType)
 {
     if (m_pPage->m_pResources == NULL) {
         m_pPage->m_pResources = new CPDF_Dictionary;
         int objnum = m_pDocument->AddIndirectObject(m_pPage->m_pResources);
         m_pPage->m_pFormDict->SetAtReference("Resources", m_pDocument, objnum);
     }
@@ skipping 86 matching lines @@
         }
         ProcessForm(buf, pBuf, size, matrix);
         FX_Free(pBuf);
         FX_Free(pContentArray);
     } else if (type == PDFOBJ_STREAM) {
         CPDF_StreamAcc contentStream;
         contentStream.LoadAllData((CPDF_Stream*)pContent);
         ProcessForm(buf, contentStream.GetData(), contentStream.GetSize(), matrix);
     }
     CPDF_Stream* pStream = new CPDF_Stream(NULL, 0, NULL);
-    pStream->SetData(buf.GetBuffer(), buf.GetLength(), FALSE, FALSE);
+    pStream->SetData(buf.GetBuffer(), buf.GetLength(), false, false);
     m_pDocument->AddIndirectObject(pStream);
     m_pPage->m_pFormDict->SetAtReference("Contents", m_pDocument, pStream->GetObjNum());
 }