FX Bool considered harmful, part 3

fpdfsdk/src/javascript/app.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../third_party/base/nonstd_unique_ptr.h"
 #include "../../include/javascript/JavaScript.h"
 #include "../../include/javascript/IJavaScript.h"
 #include "../../include/javascript/JS_Define.h"
@@ skipping 116 matching lines @@
 }
 
 app::~app(void)
 {
         for (int i=0,sz=m_aTimer.GetSize(); i<sz; i++)
                 delete m_aTimer[i];
 
         m_aTimer.RemoveAll();
 }
 
-FX_BOOL app::activeDocs(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
+bool app::activeDocs(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
     if (!vp.IsGetting())
-        return FALSE;
+        return false;
 
     CJS_Context* pContext = (CJS_Context *)cc;
     CPDFDoc_Environment* pApp = pContext->GetReaderApp();
     CJS_Runtime* pRuntime = pContext->GetJSRuntime();
     CPDFSDK_Document* pCurDoc = pContext->GetReaderDocument();
     CJS_Array aDocs(pRuntime->GetIsolate());
     if (CPDFSDK_Document* pDoc = pApp->GetSDKDocument())
     {
         CJS_Document* pJSDocument = NULL;
         if (pDoc == pCurDoc)
         {
             JSFXObject pObj = JS_GetThisObj(*pRuntime);
             if (JS_GetObjDefnID(pObj) == JS_GetObjDefnID(*pRuntime, L"Document"))
                 pJSDocument = (CJS_Document*)JS_GetPrivate(pRuntime->GetIsolate(),pObj);
         }
         else
         {
             JSFXObject pObj = JS_NewFxDynamicObj(*pRuntime, pContext, JS_GetObjDefnID(*pRuntime,L"Document"));
             pJSDocument = (CJS_Document*)JS_GetPrivate(pRuntime->GetIsolate(),pObj);
             ASSERT(pJSDocument != NULL);
         }
         aDocs.SetElement(0,CJS_Value(pRuntime->GetIsolate(),pJSDocument));
     }
     if (aDocs.GetLength() > 0)
         vp << aDocs;
     else
         vp.SetNull();
 
-    return TRUE;
+    return true;
 }
 
-FX_BOOL app::calculate(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
+bool app::calculate(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
         if (vp.IsSetting())
         {
                 bool bVP;
                 vp >> bVP;
-                m_bCalculate = (FX_BOOL)bVP;
+                m_bCalculate = (bool)bVP;
 
                 CJS_Context* pContext = (CJS_Context*)cc;
                 CPDFDoc_Environment* pApp = pContext->GetReaderApp();
                 CJS_Runtime* pRuntime = pContext->GetJSRuntime();
                 CJS_Array aDocs(pRuntime->GetIsolate());
                 if (CPDFSDK_Document* pDoc = pApp->GetSDKDocument())
-                        pDoc->GetInterForm()->EnableCalculate((FX_BOOL)m_bCalculate);
+                        pDoc->GetInterForm()->EnableCalculate((bool)m_bCalculate);
         }
         else
         {
                 vp << (bool)m_bCalculate;
         }
-        return TRUE;
+        return true;
 }
 
-FX_BOOL app::formsVersion(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
+bool app::formsVersion(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
         if (vp.IsGetting())
         {
                 vp << JS_NUM_FORMSVERSION;
-                return TRUE;
+                return true;
         }
 
-        return FALSE;
+        return false;
 }
 
-FX_BOOL app::viewerType(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
+bool app::viewerType(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
         if (vp.IsGetting())
         {
                 vp << L"unknown";
-                return TRUE;
+                return true;
         }
 
-        return FALSE;
+        return false;
 }
 
-FX_BOOL app::viewerVariation(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
+bool app::viewerVariation(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
         if (vp.IsGetting())
         {
                 vp << JS_STR_VIEWERVARIATION;
-                return TRUE;
+                return true;
         }
 
-        return FALSE;
+        return false;
 }
 
-FX_BOOL app::viewerVersion(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
+bool app::viewerVersion(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
         if (vp.IsGetting())
         {
                 vp << JS_STR_VIEWERVERSION;
-                return TRUE;
+                return true;
         }
 
-        return FALSE;
+        return false;
 }
 
-FX_BOOL app::platform(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
+bool app::platform(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
         if (vp.IsGetting())
         {
                 vp << JS_STR_PLATFORM;
-                return TRUE;
+                return true;
         }
 
-        return FALSE;
+        return false;
 }
 
-FX_BOOL app::language(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
+bool app::language(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
         if (vp.IsGetting())
         {
                 vp << JS_STR_LANGUANGE;
-                return TRUE;
+                return true;
         }
 
-        return FALSE;
+        return false;
 }
 
 //creates a new fdf object that contains no data
 //comment: need reader support
 //note:
 //CFDF_Document * CPDFDoc_Environment::NewFDF();
-FX_BOOL app::newFDF(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool app::newFDF(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
-        return TRUE;
+        return true;
 }
 //opens a specified pdf document and returns its document object
 //comment:need reader support
 //note: as defined in js reference, the proto of this function's fourth parmeters, how old an fdf document while do not show it.
 //CFDF_Document * CPDFDoc_Environment::OpenFDF(string strPath,bool bUserConv);
 
-FX_BOOL app::openFDF(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool app::openFDF(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
-        return TRUE;
+        return true;
 }
 
-FX_BOOL app::alert(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool app::alert(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         int iSize = params.size();
         if (iSize < 1)
-                return FALSE;
+                return false;
 
         CFX_WideString swMsg = L"";
         CFX_WideString swTitle = L"";
         int iIcon = 0;
         int iType = 0;
 
         v8::Isolate* isolate = GetIsolate(cc);
 
         if (iSize == 1)
         {
@@ skipping 36 matching lines @@
 
                                         delete pValue;
                                 }
                         }
 
                         if (swTitle == L"")
                                 swTitle = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSALERT);
                 }
                 else if (params[0].GetType() == VT_boolean)
                 {
-                        FX_BOOL bGet = params[0].ToBool();
+                        bool bGet = params[0].ToBool();
                         if (bGet)
                                 swMsg = L"true";
                         else
                                 swMsg = L"false";
 
                         swTitle = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSALERT);
                 }
                 else
                 {
                         swMsg = params[0].ToCFXWideString();
                         swTitle = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSALERT);
                 }
         }
         else
         {
                 if (params[0].GetType() == VT_boolean)
                 {
-                        FX_BOOL bGet = params[0].ToBool();
+                        bool bGet = params[0].ToBool();
                         if (bGet)
                                 swMsg = L"true";
                         else
                                 swMsg = L"false";
                 }
                 else
                 {
                         swMsg = params[0].ToCFXWideString();
                 }
                 swTitle = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSALERT);
@@ skipping 11 matching lines @@
 
 
         CJS_Context* pContext = (CJS_Context*)cc;
         ASSERT(pContext != NULL);
         CJS_Runtime* pRuntime = pContext->GetJSRuntime();
         ASSERT(pRuntime != NULL);
         pRuntime->BeginBlock();
         vRet = MsgBox(pRuntime->GetReaderApp(), JSGetPageView(cc), swMsg.c_str(), swTitle.c_str(), iType, iIcon);
         pRuntime->EndBlock();
 
-        return TRUE;
+        return true;
 }
 
 
-FX_BOOL app::beep(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool app::beep(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         if (params.size() == 1)
         {
                 CJS_Context* pContext = (CJS_Context*)cc;
                 CJS_Runtime* pRuntime = pContext->GetJSRuntime();
                 CPDFDoc_Environment * pEnv = pRuntime->GetReaderApp();
                 pEnv->JS_appBeep(params[0].ToInt());
-                return TRUE;
+                return true;
         }
 
         sError = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSPARAMERROR);
-        return FALSE;
+        return false;
 }
 
-FX_BOOL app::findComponent(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool app::findComponent(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
-        return TRUE;
+        return true;
 }
 
-FX_BOOL app::popUpMenuEx(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool app::popUpMenuEx(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
-        return FALSE;
+        return false;
 }
 
-FX_BOOL app::fs(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
+bool app::fs(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
-        return FALSE;
+        return false;
 }
 
-FX_BOOL app::setInterval(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool app::setInterval(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         CJS_Context* pContext = (CJS_Context*)cc;
         if (params.size() > 2 || params.size() == 0)
         {
                 sError = JSGetStringFromID(pContext, IDS_STRING_JSPARAMERROR);
-                return FALSE;
+                return false;
         }
 
         CFX_WideString script = params.size() > 0 ?  params[0].ToCFXWideString() : L"";
         if (script.IsEmpty())
         {
                 sError = JSGetStringFromID(pContext, IDS_STRING_JSAFNUMBER_KEYSTROKE);
-                return TRUE;
+                return true;
         }
 
         CJS_Runtime* pRuntime = pContext->GetJSRuntime();
         FX_DWORD dwInterval = params.size() > 1 ? params[1].ToInt() : 1000;
 
         CPDFDoc_Environment* pApp = pRuntime->GetReaderApp();
         ASSERT(pApp);
         CJS_Timer* pTimer = new CJS_Timer(this, pApp);
         m_aTimer.Add(pTimer);
 
         pTimer->SetType(0);
         pTimer->SetRuntime(pRuntime);
         pTimer->SetJScript(script);
         pTimer->SetTimeOut(0);
 //      pTimer->SetStartTime(GetTickCount());
         pTimer->SetJSTimer(dwInterval);
 
         JSFXObject pRetObj = JS_NewFxDynamicObj(*pRuntime, pContext, JS_GetObjDefnID(*pRuntime, L"TimerObj"));
 
         CJS_TimerObj* pJS_TimerObj = (CJS_TimerObj*)JS_GetPrivate(pRuntime->GetIsolate(),pRetObj);
         ASSERT(pJS_TimerObj != NULL);
 
         TimerObj* pTimerObj = (TimerObj*)pJS_TimerObj->GetEmbedObject();
         ASSERT(pTimerObj != NULL);
 
         pTimerObj->SetTimer(pTimer);
 
         vRet = pRetObj;
 
-        return TRUE;
+        return true;
 }
 
-FX_BOOL app::setTimeOut(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool app::setTimeOut(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         if (params.size() > 2 || params.size() == 0)
         {
                 sError = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSPARAMERROR);
-                return FALSE;
+                return false;
         }
 
         CJS_Context* pContext = (CJS_Context*)cc;
         ASSERT(pContext != NULL);
         CJS_Runtime* pRuntime = pContext->GetJSRuntime();
         ASSERT(pRuntime != NULL);
 
         CFX_WideString script = params.size() > 0 ? params[0].ToCFXWideString() : L"";
         if (script.IsEmpty())
         {
                 sError = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSAFNUMBER_KEYSTROKE);
-                return TRUE;
+                return true;
         }
 
         FX_DWORD dwTimeOut = params.size() > 1 ? params[1].ToInt() : 1000;
 
         CPDFDoc_Environment* pApp = pRuntime->GetReaderApp();
         ASSERT(pApp);
 
         CJS_Timer* pTimer = new CJS_Timer(this, pApp);
         m_aTimer.Add(pTimer);
 
         pTimer->SetType(1);
         pTimer->SetRuntime(pRuntime);
         pTimer->SetJScript(script);
         pTimer->SetTimeOut(dwTimeOut);
         pTimer->SetJSTimer(dwTimeOut);
 
         JSFXObject pRetObj = JS_NewFxDynamicObj(*pRuntime, pContext, JS_GetObjDefnID(*pRuntime, L"TimerObj"));
 
         CJS_TimerObj* pJS_TimerObj = (CJS_TimerObj*)JS_GetPrivate(pRuntime->GetIsolate(),pRetObj);
         ASSERT(pJS_TimerObj != NULL);
 
         TimerObj* pTimerObj = (TimerObj*)pJS_TimerObj->GetEmbedObject();
         ASSERT(pTimerObj != NULL);
 
         pTimerObj->SetTimer(pTimer);
 
         vRet = pRetObj;
 
-        return TRUE;
+        return true;
 }
 
-FX_BOOL app::clearTimeOut(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool app::clearTimeOut(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         CJS_Context* pContext = (CJS_Context*)cc;
         ASSERT(pContext != NULL);
         CJS_Runtime* pRuntime = pContext->GetJSRuntime();
         ASSERT(pRuntime != NULL);
 
         if (params.size() != 1)
         {
                 sError = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSPARAMERROR);
-                return FALSE;
+                return false;
         }
 
         if (params[0].GetType() == VT_fxobject)
         {
                 JSFXObject pObj = params[0].ToV8Object();
                 {
                         if (JS_GetObjDefnID(pObj) == JS_GetObjDefnID(*pRuntime, L"TimerObj"))
                         {
                                 if (CJS_Object* pJSObj = params[0].ToCJSObject())
                                 {
@@ skipping 14 matching lines @@
 
                                                         delete pTimer;
                                                         pTimerObj->SetTimer(NULL);
                                                 }
                                         }
                                 }
                         }
                 }
         }
 
-        return TRUE;
+        return true;
 }
 
-FX_BOOL app::clearInterval(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool app::clearInterval(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         CJS_Context* pContext = (CJS_Context*)cc;
         ASSERT(pContext != NULL);
         CJS_Runtime* pRuntime = pContext->GetJSRuntime();
         ASSERT(pRuntime != NULL);
 
         if (params.size() != 1)
         {
                 sError = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSPARAMERROR);
-                return FALSE;
+                return false;
         }
 
         if (params[0].GetType() == VT_fxobject)
         {
                 JSFXObject pObj = params[0].ToV8Object();
                 {
                         if (JS_GetObjDefnID(pObj) == JS_GetObjDefnID(*pRuntime, L"TimerObj"))
                         {
                                 if (CJS_Object* pJSObj = params[0].ToCJSObject())
                                 {
@@ skipping 14 matching lines @@
 
                                                         delete pTimer;
                                                         pTimerObj->SetTimer(NULL);
                                                 }
                                         }
                                 }
                         }
                 }
         }
 
-        return TRUE;
+        return true;
 }
 
-FX_BOOL app::execMenuItem(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool app::execMenuItem(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
-        return FALSE;
+        return false;
 }
 
 void app::TimerProc(CJS_Timer* pTimer)
 {
         ASSERT(pTimer != NULL);
 
         switch (pTimer->GetType())
         {
         case 0: //interval
                 RunJsScript(pTimer->GetRuntime(), pTimer->GetJScript());
@@ skipping 17 matching lines @@
         {
                 IFXJS_Context* pContext = pRuntime->NewContext();
                 ASSERT(pContext != NULL);
                 pContext->OnExternal_Exec();
                 CFX_WideString wtInfo;
                 pContext->RunScript(wsScript,wtInfo);
                 pRuntime->ReleaseContext(pContext);
         }
 }
 
-FX_BOOL app::goBack(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool app::goBack(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
   // Not supported.
-  return TRUE;
+  return true;
 }
 
-FX_BOOL app::goForward(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool app::goForward(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
   // Not supported.
-  return TRUE;
+  return true;
 }
 
-FX_BOOL app::mailMsg(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool app::mailMsg(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         CJS_Context* pContext = (CJS_Context*)cc;
         v8::Isolate* isolate = GetIsolate(cc);
 
-        FX_BOOL bUI = TRUE;
+        bool bUI = true;
         CFX_WideString cTo = L"";
         CFX_WideString cCc = L"";
         CFX_WideString cBcc = L"";
         CFX_WideString cSubject = L"";
         CFX_WideString cMsg = L"";
 
         if (params.size() < 1)
-                return FALSE;
+                return false;
 
         if (params[0].GetType() == VT_object)
         {
                 JSObject pObj = params[0].ToV8Object();
 
                 v8::Local<v8::Value> pValue = JS_GetObjectElement(isolate, pObj, L"bUI");
                 bUI = CJS_Value(isolate, pValue, GET_VALUE_TYPE(pValue)).ToBool();
 
                 pValue = JS_GetObjectElement(isolate, pObj, L"cTo");
                 cTo = CJS_Value(isolate, pValue, GET_VALUE_TYPE(pValue)).ToCFXWideString();
 
                 pValue = JS_GetObjectElement(isolate, pObj, L"cCc");
                 cCc = CJS_Value(isolate, pValue, GET_VALUE_TYPE(pValue)).ToCFXWideString();
 
                 pValue = JS_GetObjectElement(isolate, pObj, L"cBcc");
                 cBcc = CJS_Value(isolate, pValue, GET_VALUE_TYPE(pValue)).ToCFXWideString();
 
                 pValue = JS_GetObjectElement(isolate, pObj, L"cSubject");
                 cSubject = CJS_Value(isolate, pValue, GET_VALUE_TYPE(pValue)).ToCFXWideString();
 
                 pValue = JS_GetObjectElement(isolate, pObj, L"cMsg");
                 cMsg = CJS_Value(isolate, pValue, GET_VALUE_TYPE(pValue)).ToCFXWideString();
         } else {
                 if (params.size() < 2)
-                        return FALSE;
+                        return false;
 
                 bUI = params[0].ToBool();
                 cTo = params[1].ToCFXWideString();
 
                 if (params.size() >= 3)
                         cCc = params[2].ToCFXWideString();
                 if (params.size() >= 4)
                         cBcc = params[3].ToCFXWideString();
                 if (params.size() >= 5)
                         cSubject = params[4].ToCFXWideString();
                 if (params.size() >= 6)
                         cMsg = params[5].ToCFXWideString();
         }
 
         CJS_Runtime* pRuntime = pContext->GetJSRuntime();
         ASSERT(pRuntime != NULL);
 
         CPDFDoc_Environment* pApp = pContext->GetReaderApp();
         ASSERT(pApp != NULL);
 
         pRuntime->BeginBlock();
         pApp->JS_docmailForm(NULL, 0, bUI, cTo.c_str(), cSubject.c_str(), cCc.c_str(), cBcc.c_str(), cMsg.c_str());
         pRuntime->EndBlock();
 
-        return FALSE;
+        return false;
 }
 
-FX_BOOL app::launchURL(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool app::launchURL(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
   // Unsafe, not supported.
-  return TRUE;
+  return true;
 }
 
-FX_BOOL app::runtimeHighlight(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
+bool app::runtimeHighlight(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
         if (vp.IsSetting())
         {
                 vp>>m_bRuntimeHighLight;
         }
         else
         {
                 vp<<m_bRuntimeHighLight;
         }
 
-        return TRUE;
+        return true;
 }
 
-FX_BOOL app::fullscreen(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
+bool app::fullscreen(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
-        return FALSE;
+        return false;
 }
 
-FX_BOOL app::popUpMenu(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool app::popUpMenu(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
-        return FALSE;
+        return false;
 }
 
 
-FX_BOOL app::browseForDoc(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool app::browseForDoc(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
   // Unsafe, not supported.
-  return TRUE;
+  return true;
 }
 
 CFX_WideString app::SysPathToPDFPath(const CFX_WideString& sOldPath)
 {
         CFX_WideString sRet = L"/";
 
         for (int i=0,sz=sOldPath.GetLength(); i<sz; i++)
         {
                 wchar_t c = sOldPath.GetAt(i);
                 if (c == L':')
                 {
                 }
                 else
                 {
                         if (c == L'\\')
                         {
                                 sRet += L"/";
                         }
                         else
                         {
                                 sRet += c;
                         }
                 }
         }
 
         return sRet;
 }
 
-FX_BOOL app::newDoc(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool app::newDoc(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
-        return FALSE;
+        return false;
 }
 
-FX_BOOL app::openDoc(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool app::openDoc(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
-        return FALSE;
+        return false;
 }
 
-FX_BOOL app::response(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool app::response(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         CFX_WideString swQuestion = L"";
         CFX_WideString swLabel = L"";
         CFX_WideString swTitle = L"PDF";
         CFX_WideString swDefault = L"";
         bool bPassWord = false;
 
         v8::Isolate* isolate = GetIsolate(cc);
 
         int iLength = params.size();
@@ skipping 50 matching lines @@
     memset(pBuff.get(), 0, MAX_INPUT_BYTES + 2);
     int nLengthBytes = pApp->JS_appResponse(swQuestion.c_str(),
                                             swTitle.c_str(),
                                             swDefault.c_str(),
                                             swLabel.c_str(),
                                             bPassWord,
                                             pBuff.get(),
                                             MAX_INPUT_BYTES);
     if (nLengthBytes <= 0) {
         vRet.SetNull();
-        return FALSE;
+        return false;
     }
     nLengthBytes = std::min(nLengthBytes, MAX_INPUT_BYTES);
 
     CFX_WideString ret_string =
         CFX_WideString::FromUTF16LE((unsigned short*)pBuff.get(),
                                     nLengthBytes / sizeof(unsigned short));
     vRet = ret_string.c_str();
-    return TRUE;
+    return true;
 }
 
-FX_BOOL app::media(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
+bool app::media(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
-        return FALSE;
+        return false;
 }
 
-FX_BOOL app::execDialog(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool app::execDialog(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
-        return TRUE;
+        return true;
 }