FX Bool considered harmful, part 3

core/src/fxcodec/codec/fx_codec_jpeg.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include <setjmp.h>
 
 #include "../../../include/fxcodec/fx_codec.h"
 #include "../../../include/fxcrt/fx_safe_types.h"
@@ skipping 60 matching lines @@
     static void _error_do_nothing1(j_common_ptr cinfo, int) {}
 };
 extern "C" {
     static void _error_do_nothing2(j_common_ptr cinfo, char*) {}
 };
 #define JPEG_MARKER_EXIF                (JPEG_APP0 + 1)
 #define JPEG_MARKER_ICC                 (JPEG_APP0 + 2)
 #define JPEG_MARKER_AUTHORTIME  (JPEG_APP0 + 3)
 #define JPEG_MARKER_MAXSIZE     0xFFFF
 #define JPEG_OVERHEAD_LEN       14
-static  FX_BOOL _JpegEmbedIccProfile(j_compress_ptr cinfo, const uint8_t* icc_buf_ptr, FX_DWORD icc_length)
+static  bool _JpegEmbedIccProfile(j_compress_ptr cinfo, const uint8_t* icc_buf_ptr, FX_DWORD icc_length)
 {
     if(icc_buf_ptr == NULL || icc_length == 0) {
-        return FALSE;
+        return false;
     }
     FX_DWORD icc_segment_size = (JPEG_MARKER_MAXSIZE - 2 - JPEG_OVERHEAD_LEN);
     FX_DWORD icc_segment_num = (icc_length / icc_segment_size) + 1;
     if (icc_segment_num > 255)  {
-        return FALSE;
+        return false;
     }
     FX_DWORD icc_data_length = JPEG_OVERHEAD_LEN + (icc_segment_num > 1 ? icc_segment_size : icc_length);
     uint8_t* icc_data = FX_Alloc(uint8_t, icc_data_length);
     FXSYS_memcpy(icc_data, "\x49\x43\x43\x5f\x50\x52\x4f\x46\x49\x4c\x45\x00", 12);
     icc_data[13] = (uint8_t)icc_segment_num;
     for (uint8_t i = 0; i < (icc_segment_num - 1); i++) {
         icc_data[12] = i + 1;
         FXSYS_memcpy(icc_data + JPEG_OVERHEAD_LEN, icc_buf_ptr + i * icc_segment_size, icc_segment_size);
         jpeg_write_marker(cinfo, JPEG_MARKER_ICC, icc_data, icc_data_length);
     }
     icc_data[12] = (uint8_t)icc_segment_num;
     FX_DWORD icc_size = (icc_segment_num - 1) * icc_segment_size;
     FXSYS_memcpy(icc_data + JPEG_OVERHEAD_LEN, icc_buf_ptr + icc_size, icc_length - icc_size);
     jpeg_write_marker(cinfo, JPEG_MARKER_ICC, icc_data, JPEG_OVERHEAD_LEN + icc_length - icc_size);
     FX_Free(icc_data);
-    return TRUE;
+    return true;
 }
 extern "C" {
     static void _dest_do_nothing(j_compress_ptr cinfo) {}
 };
 extern "C" {
     static boolean _dest_empty(j_compress_ptr cinfo)
     {
-        return FALSE;
+        return false;
     }
 };
 #define JPEG_BLOCK_SIZE 1048576
 static void _JpegEncode(const CFX_DIBSource* pSource, uint8_t*& dest_buf, FX_STRSIZE& dest_size, int quality, const uint8_t* icc_buf, FX_DWORD icc_length)
 {
     struct jpeg_error_mgr jerr;
     jerr.error_exit = _error_do_nothing;
     jerr.emit_message = _error_do_nothing1;
     jerr.output_message = _error_do_nothing;
     jerr.format_message = _error_do_nothing2;
@@ skipping 47 matching lines @@
         cinfo.in_color_space = JCS_RGB;
     } else {
         cinfo.in_color_space = JCS_CMYK;
     }
     uint8_t* line_buf = NULL;
     if (nComponents > 1) {
         line_buf = FX_Alloc2D(uint8_t, width, nComponents);
     }
     jpeg_set_defaults(&cinfo);
     if(quality != 75) {
-        jpeg_set_quality(&cinfo, quality, TRUE);
+        jpeg_set_quality(&cinfo, quality, true);
     }
-    jpeg_start_compress(&cinfo, TRUE);
+    jpeg_start_compress(&cinfo, true);
     _JpegEmbedIccProfile(&cinfo, icc_buf, icc_length);
     JSAMPROW row_pointer[1];
     JDIMENSION row;
     while (cinfo.next_scanline < cinfo.image_height) {
         const uint8_t* src_scan = pSource->GetScanline(cinfo.next_scanline);
         if (nComponents > 1) {
             uint8_t* dest_scan = line_buf;
             if (nComponents == 3) {
                 for (int i = 0; i < width; i ++) {
                     dest_scan[0] = src_scan[2];
@@ skipping 20 matching lines @@
             dest.free_in_buffer += JPEG_BLOCK_SIZE;
         }
     }
     jpeg_finish_compress(&cinfo);
     jpeg_destroy_compress(&cinfo);
     if (line_buf) {
         FX_Free(line_buf);
     }
     dest_size = dest_buf_length - (FX_STRSIZE)dest.free_in_buffer;
 }
-static FX_BOOL _JpegLoadInfo(const uint8_t* src_buf, FX_DWORD src_size, int& width, int& height,
-                             int& num_components, int& bits_per_components, FX_BOOL& color_transform,
+static bool _JpegLoadInfo(const uint8_t* src_buf, FX_DWORD src_size, int& width, int& height,
+                             int& num_components, int& bits_per_components, bool& color_transform,
                              uint8_t** icc_buf_ptr, FX_DWORD* icc_length)
 {
     _JpegScanSOI(src_buf, src_size);
     struct jpeg_decompress_struct cinfo;
     struct jpeg_error_mgr jerr;
     jerr.error_exit = _error_fatal;
     jerr.emit_message = _error_do_nothing1;
     jerr.output_message = _error_do_nothing;
     jerr.format_message = _error_do_nothing2;
     jerr.reset_error_mgr = _error_do_nothing;
     jerr.trace_level = 0;
     cinfo.err = &jerr;
     jmp_buf mark;
     cinfo.client_data = &mark;
     if (setjmp(mark) == -1) {
-        return FALSE;
+        return false;
     }
     jpeg_create_decompress(&cinfo);
     struct jpeg_source_mgr src;
     src.init_source = _src_do_nothing;
     src.term_source = _src_do_nothing;
     src.skip_input_data = _src_skip_data;
     src.fill_input_buffer = _src_fill_buffer;
     src.resync_to_restart = _src_resync;
     src.bytes_in_buffer = src_size;
     src.next_input_byte = src_buf;
     cinfo.src = &src;
     if (setjmp(mark) == -1) {
         jpeg_destroy_decompress(&cinfo);
-        return FALSE;
+        return false;
     }
     if(icc_buf_ptr && icc_length) {
         jpeg_save_markers(&cinfo, JPEG_MARKER_ICC, JPEG_MARKER_MAXSIZE);
     }
-    int ret = jpeg_read_header(&cinfo, TRUE);
+    int ret = jpeg_read_header(&cinfo, true);
     if (ret != JPEG_HEADER_OK) {
         jpeg_destroy_decompress(&cinfo);
-        return FALSE;
+        return false;
     }
     width = cinfo.image_width;
     height = cinfo.image_height;
     num_components = cinfo.num_components;
     color_transform = cinfo.jpeg_color_space == JCS_YCbCr || cinfo.jpeg_color_space == JCS_YCCK;
     bits_per_components = cinfo.data_precision;
     if(icc_buf_ptr != NULL) {
         *icc_buf_ptr = NULL;
     }
     if(icc_length != NULL) {
         *icc_length = 0;
     }
     jpeg_destroy_decompress(&cinfo);
-    return TRUE;
+    return true;
 }
 class CCodec_JpegDecoder : public CCodec_ScanlineDecoder
 {
 public:
     CCodec_JpegDecoder();
     ~CCodec_JpegDecoder();
-    FX_BOOL                             Create(const uint8_t* src_buf, FX_DWORD src_size, int width, int height, int nComps,
-                               FX_BOOL ColorTransform, IFX_JpegProvider* pJP);
+    bool                                Create(const uint8_t* src_buf, FX_DWORD src_size, int width, int height, int nComps,
+                               bool ColorTransform, IFX_JpegProvider* pJP);
     virtual void                Destroy()
     {
         delete this;
     }
     virtual void                v_DownScale(int dest_width, int dest_height);
-    virtual FX_BOOL             v_Rewind();
+    virtual bool                v_Rewind();
     virtual uint8_t*    v_GetNextLine();
     virtual FX_DWORD    GetSrcOffset();
     jmp_buf             m_JmpBuf;
     struct jpeg_decompress_struct cinfo;
     struct jpeg_error_mgr jerr;
     struct jpeg_source_mgr src;
     const uint8_t*      m_SrcBuf;
     FX_DWORD    m_SrcSize;
     uint8_t*    m_pScanlineBuf;
-    FX_BOOL             InitDecode();
-    FX_BOOL             m_bInited, m_bStarted, m_bJpegTransform;
+    bool                InitDecode();
+    bool                m_bInited, m_bStarted, m_bJpegTransform;
 protected:
     IFX_JpegProvider*   m_pExtProvider;
     void*                               m_pExtContext;
     FX_DWORD                    m_nDefaultScaleDenom;
 };
 CCodec_JpegDecoder::CCodec_JpegDecoder()
 {
     m_pScanlineBuf = NULL;
     m_DownScale = 1;
-    m_bStarted = FALSE;
-    m_bInited = FALSE;
+    m_bStarted = false;
+    m_bInited = false;
     m_pExtProvider = NULL;
     m_pExtContext = NULL;
     FXSYS_memset(&cinfo, 0, sizeof(cinfo));
     FXSYS_memset(&jerr, 0, sizeof(jerr));
     FXSYS_memset(&src, 0, sizeof(src));
     m_nDefaultScaleDenom = 1;
 }
 CCodec_JpegDecoder::~CCodec_JpegDecoder()
 {
     if (m_pExtProvider) {
         m_pExtProvider->DestroyDecoder(m_pExtContext);
         return;
     }
     if (m_pScanlineBuf) {
         FX_Free(m_pScanlineBuf);
     }
     if (m_bInited) {
         jpeg_destroy_decompress(&cinfo);
     }
 }
-FX_BOOL CCodec_JpegDecoder::InitDecode()
+bool CCodec_JpegDecoder::InitDecode()
 {
     cinfo.err = &jerr;
     cinfo.client_data = &m_JmpBuf;
     if (setjmp(m_JmpBuf) == -1) {
-        return FALSE;
+        return false;
     }
     jpeg_create_decompress(&cinfo);
-    m_bInited = TRUE;
+    m_bInited = true;
     cinfo.src = &src;
     src.bytes_in_buffer = m_SrcSize;
     src.next_input_byte = m_SrcBuf;
     if (setjmp(m_JmpBuf) == -1) {
         jpeg_destroy_decompress(&cinfo);
-        m_bInited = FALSE;
-        return FALSE;
+        m_bInited = false;
+        return false;
     }
     cinfo.image_width = m_OrigWidth;
     cinfo.image_height = m_OrigHeight;
-    int ret = jpeg_read_header(&cinfo, TRUE);
+    int ret = jpeg_read_header(&cinfo, true);
     if (ret != JPEG_HEADER_OK) {
-        return FALSE;
+        return false;
     }
     if (cinfo.saw_Adobe_marker) {
-        m_bJpegTransform = TRUE;
+        m_bJpegTransform = true;
     }
     if (cinfo.num_components == 3 && !m_bJpegTransform) {
         cinfo.out_color_space = cinfo.jpeg_color_space;
     }
     m_OrigWidth = cinfo.image_width;
     m_OrigHeight = cinfo.image_height;
     m_OutputWidth = m_OrigWidth;
     m_OutputHeight = m_OrigHeight;
     m_nDefaultScaleDenom = cinfo.scale_denom;
-    return TRUE;
+    return true;
 }
-FX_BOOL CCodec_JpegDecoder::Create(const uint8_t* src_buf, FX_DWORD src_size, int width, int height,
-                                   int nComps, FX_BOOL ColorTransform, IFX_JpegProvider* pJP)
+bool CCodec_JpegDecoder::Create(const uint8_t* src_buf, FX_DWORD src_size, int width, int height,
+                                   int nComps, bool ColorTransform, IFX_JpegProvider* pJP)
 {
     if (pJP) {
         m_pExtProvider = pJP;
         m_pExtContext = m_pExtProvider->CreateDecoder(src_buf, src_size, width, height, nComps, ColorTransform);
         return m_pExtContext != NULL;
     }
     _JpegScanSOI(src_buf, src_size);
     m_SrcBuf = src_buf;
     m_SrcSize = src_size;
     jerr.error_exit = _error_fatal;
     jerr.emit_message = _error_do_nothing1;
     jerr.output_message = _error_do_nothing;
     jerr.format_message = _error_do_nothing2;
     jerr.reset_error_mgr = _error_do_nothing;
     src.init_source = _src_do_nothing;
     src.term_source = _src_do_nothing;
     src.skip_input_data = _src_skip_data;
     src.fill_input_buffer = _src_fill_buffer;
     src.resync_to_restart = _src_resync;
     m_bJpegTransform = ColorTransform;
     if(src_size > 1 && FXSYS_memcmp(src_buf + src_size - 2, "\xFF\xD9", 2) != 0) {
         ((uint8_t*)src_buf)[src_size - 2] = 0xFF;
         ((uint8_t*)src_buf)[src_size - 1] = 0xD9;
     }
     m_OutputWidth = m_OrigWidth = width;
     m_OutputHeight = m_OrigHeight = height;
     if (!InitDecode()) {
-        return FALSE;
+        return false;
     }
     if (cinfo.num_components < nComps) {
-        return FALSE;
+        return false;
     }
     if ((int)cinfo.image_width < width) {
-        return FALSE;
+        return false;
     }
     m_Pitch = (cinfo.image_width * cinfo.num_components + 3) / 4 * 4;
     m_pScanlineBuf = FX_Alloc(uint8_t, m_Pitch);
     m_nComps = cinfo.num_components;
     m_bpc = 8;
-    m_bColorTransformed = FALSE;
-    m_bStarted = FALSE;
-    return TRUE;
+    m_bColorTransformed = false;
+    m_bStarted = false;
+    return true;
 }
 extern "C" {
     int32_t FX_GetDownsampleRatio(int32_t originWidth, int32_t originHeight, int32_t downsampleWidth, int32_t downsampleHeight)
     {
         int iratio_w = originWidth / downsampleWidth;
         int iratio_h = originHeight / downsampleHeight;
         int ratio = (iratio_w > iratio_h) ? iratio_h : iratio_w;
         if (ratio >= 8) {
             return 8;
         }
@@ skipping 14 matching lines @@
     }
     int old_scale = m_DownScale;
     m_DownScale = FX_GetDownsampleRatio(m_OrigWidth, m_OrigHeight, dest_width, dest_height);
     m_OutputWidth = (m_OrigWidth + m_DownScale - 1) / m_DownScale;
     m_OutputHeight = (m_OrigHeight + m_DownScale - 1) / m_DownScale;
     m_Pitch = (m_OutputWidth * m_nComps + 3) / 4 * 4;
     if (old_scale != m_DownScale) {
         m_NextLine = -1;
     }
 }
-FX_BOOL CCodec_JpegDecoder::v_Rewind()
+bool CCodec_JpegDecoder::v_Rewind()
 {
     if (m_pExtProvider) {
         return m_pExtProvider->Rewind(m_pExtContext);
     }
     if (m_bStarted) {
         jpeg_destroy_decompress(&cinfo);
         if (!InitDecode()) {
-            return FALSE;
+            return false;
         }
     }
     if (setjmp(m_JmpBuf) == -1) {
-        return FALSE;
+        return false;
     }
     cinfo.scale_denom = m_nDefaultScaleDenom * m_DownScale;
     m_OutputWidth = (m_OrigWidth + m_DownScale - 1) / m_DownScale;
     m_OutputHeight = (m_OrigHeight + m_DownScale - 1) / m_DownScale;
     if (!jpeg_start_decompress(&cinfo)) {
         jpeg_destroy_decompress(&cinfo);
-        return FALSE;
+        return false;
     }
     if ((int)cinfo.output_width > m_OrigWidth) {
-        FXSYS_assert(FALSE);
-        return FALSE;
+        FXSYS_assert(false);
+        return false;
     }
-    m_bStarted = TRUE;
-    return TRUE;
+    m_bStarted = true;
+    return true;
 }
 uint8_t* CCodec_JpegDecoder::v_GetNextLine()
 {
     if (m_pExtProvider) {
         return m_pExtProvider->GetNextLine(m_pExtContext);
     }
     int nlines = jpeg_read_scanlines(&cinfo, &m_pScanlineBuf, 1);
     if (nlines < 1) {
         return NULL;
     }
     return m_pScanlineBuf;
 }
 FX_DWORD CCodec_JpegDecoder::GetSrcOffset()
 {
     if (m_pExtProvider) {
         return m_pExtProvider->GetSrcOffset(m_pExtContext);
     }
     return (FX_DWORD)(m_SrcSize - src.bytes_in_buffer);
 }
 ICodec_ScanlineDecoder* CCodec_JpegModule::CreateDecoder(const uint8_t* src_buf, FX_DWORD src_size,
-        int width, int height, int nComps, FX_BOOL ColorTransform)
+        int width, int height, int nComps, bool ColorTransform)
 {
     if (src_buf == NULL || src_size == 0) {
         return NULL;
     }
     CCodec_JpegDecoder* pDecoder = new CCodec_JpegDecoder;
     if (!pDecoder->Create(src_buf, src_size, width, height, nComps, ColorTransform, m_pExtProvider)) {
         delete pDecoder;
         return NULL;
     }
     return pDecoder;
 }
-FX_BOOL CCodec_JpegModule::LoadInfo(const uint8_t* src_buf, FX_DWORD src_size, int& width, int& height,
-                                    int& num_components, int& bits_per_components, FX_BOOL& color_transform,
+bool CCodec_JpegModule::LoadInfo(const uint8_t* src_buf, FX_DWORD src_size, int& width, int& height,
+                                    int& num_components, int& bits_per_components, bool& color_transform,
                                     uint8_t** icc_buf_ptr, FX_DWORD* icc_length)
 {
     if (m_pExtProvider) {
         return m_pExtProvider->LoadInfo(src_buf, src_size, width, height,
                                         num_components, bits_per_components, color_transform,
                                         icc_buf_ptr, icc_length);
     }
     return _JpegLoadInfo(src_buf, src_size, width, height, num_components, bits_per_components, color_transform, icc_buf_ptr, icc_length);
 }
-FX_BOOL CCodec_JpegModule::Encode(const CFX_DIBSource* pSource, uint8_t*& dest_buf, FX_STRSIZE& dest_size, int quality, const uint8_t* icc_buf, FX_DWORD icc_length)
+bool CCodec_JpegModule::Encode(const CFX_DIBSource* pSource, uint8_t*& dest_buf, FX_STRSIZE& dest_size, int quality, const uint8_t* icc_buf, FX_DWORD icc_length)
 {
     if (m_pExtProvider) {
         return m_pExtProvider->Encode(pSource, dest_buf, dest_size, quality, icc_buf, icc_length);
     }
     if(pSource->GetBPP() < 8 || pSource->GetPalette() != NULL) {
         ASSERT(pSource->GetBPP() >= 8 && pSource->GetPalette() == NULL);
-        return FALSE;
+        return false;
     }
     _JpegEncode(pSource, dest_buf, dest_size, quality, icc_buf, icc_length);
-    return TRUE;
+    return true;
 }
 struct FXJPEG_Context {
     jmp_buf                     m_JumpMark;
     jpeg_decompress_struct m_Info;
     jpeg_error_mgr      m_ErrMgr;
     jpeg_source_mgr     m_SrcMgr;
     unsigned int        m_SkipSize;
     void*               (*m_AllocFunc)(unsigned int);
     void                (*m_FreeFunc)(void*);
 };
@@ skipping 107 matching lines @@
     if (m_pExtProvider) {
         return m_pExtProvider->StartScanline(pContext, down_scale);
     }
     FXJPEG_Context* p = (FXJPEG_Context*)pContext;
     if (setjmp(p->m_JumpMark) == -1) {
         return 0;
     }
     p->m_Info.scale_denom = down_scale;
     return jpeg_start_decompress(&p->m_Info);
 }
-FX_BOOL CCodec_JpegModule::ReadScanline(void* pContext, unsigned char* dest_buf)
+bool CCodec_JpegModule::ReadScanline(void* pContext, unsigned char* dest_buf)
 {
     if (m_pExtProvider) {
         return m_pExtProvider->ReadScanline(pContext, dest_buf);
     }
     FXJPEG_Context* p = (FXJPEG_Context*)pContext;
     if (setjmp(p->m_JumpMark) == -1) {
-        return FALSE;
+        return false;
     }
     int nlines = jpeg_read_scanlines(&p->m_Info, &dest_buf, 1);
     return nlines == 1;
 }
 FX_DWORD CCodec_JpegModule::GetAvailInput(void* pContext, uint8_t** avail_buf_ptr)
 {
     if (m_pExtProvider) {
         return m_pExtProvider->GetAvailInput(pContext, avail_buf_ptr);
     }
     if(avail_buf_ptr != NULL) {
         *avail_buf_ptr = NULL;
         if(((FXJPEG_Context*)pContext)->m_SrcMgr.bytes_in_buffer > 0) {
             *avail_buf_ptr = (uint8_t*)((FXJPEG_Context*)pContext)->m_SrcMgr.next_input_byte;
         }
     }
     return (FX_DWORD)((FXJPEG_Context*)pContext)->m_SrcMgr.bytes_in_buffer;
 }