FX Bool considered harmful, part 3

core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fpdfapi/fpdf_page.h"
 #include "../../../include/fpdfapi/fpdf_module.h"
 #include "../fpdf_page/pageint.h"
 #include <limits.h>
 CPDF_Document::CPDF_Document() : CPDF_IndirectObjects(NULL)
 {
     m_pRootDict = NULL;
     m_pInfoDict = NULL;
-    m_bLinearized = FALSE;
+    m_bLinearized = false;
     m_dwFirstPageNo = 0;
     m_dwFirstPageObjNum = 0;
     m_pDocPage = CPDF_ModuleMgr::Get()->GetPageModule()->CreateDocData(this);
     m_pDocRender = CPDF_ModuleMgr::Get()->GetRenderModule()->CreateDocData(this);
 }
 void CPDF_Document::CreateNewDoc()
 {
     ASSERT(m_pRootDict == NULL && m_pInfoDict == NULL);
     m_pRootDict = new CPDF_Dictionary;
     m_pRootDict->SetAtName("Type", "Catalog");
@@ skipping 182 matching lines @@
         pWidthArray->AddInteger(*widths);
     } else {
         CPDF_Array* pWidthArray1 = new CPDF_Array;
         pWidthArray->Add(pWidthArray1);
         for (i = 0; i < size; i ++) {
             pWidthArray1->AddInteger(widths[i]);
         }
     }
     FX_Free(widths);
 }
-CPDF_Font* CPDF_Document::AddWindowsFont(LOGFONTW* pLogFont, FX_BOOL bVert, FX_BOOL bTranslateName)
+CPDF_Font* CPDF_Document::AddWindowsFont(LOGFONTW* pLogFont, bool bVert, bool bTranslateName)
 {
     LOGFONTA lfa;
     FXSYS_memcpy(&lfa, pLogFont, (char*)lfa.lfFaceName - (char*)&lfa);
     CFX_ByteString face = CFX_ByteString::FromUnicode(pLogFont->lfFaceName);
     if (face.GetLength() >= LF_FACESIZE) {
         return NULL;
     }
     FXSYS_strcpy(lfa.lfFaceName, face.c_str());
     return AddWindowsFont(&lfa, bVert, bTranslateName);
 }
 extern CFX_ByteString _FPDF_GetNameFromTT(const uint8_t* name_table, FX_DWORD name);
 CFX_ByteString _FPDF_GetPSNameFromTT(HDC hDC)
 {
     CFX_ByteString result;
     DWORD size = ::GetFontData(hDC, 'eman', 0, NULL, 0);
     if (size != GDI_ERROR) {
         LPBYTE buffer = FX_Alloc(BYTE, size);
         ::GetFontData(hDC, 'eman', 0, buffer, size);
         result = _FPDF_GetNameFromTT(buffer, 6);
         FX_Free(buffer);
     }
     return result;
 }
-CPDF_Font* CPDF_Document::AddWindowsFont(LOGFONTA* pLogFont, FX_BOOL bVert, FX_BOOL bTranslateName)
+CPDF_Font* CPDF_Document::AddWindowsFont(LOGFONTA* pLogFont, bool bVert, bool bTranslateName)
 {
     pLogFont->lfHeight = -1000;
     pLogFont->lfWidth = 0;
     HGDIOBJ hFont = CreateFontIndirectA(pLogFont);
     HDC hDC = CreateCompatibleDC(NULL);
     hFont = SelectObject(hDC, hFont);
     int tm_size = GetOutlineTextMetrics(hDC, 0, NULL);
     if (tm_size == 0) {
         hFont = SelectObject(hDC, hFont);
         DeleteObject(hFont);
         DeleteDC(hDC);
         return NULL;
     }
     LPBYTE tm_buf = FX_Alloc(BYTE, tm_size);
     OUTLINETEXTMETRIC* ptm = (OUTLINETEXTMETRIC*)tm_buf;
     GetOutlineTextMetrics(hDC, tm_size, ptm);
     int flags = 0, italicangle, ascend, descend, capheight, bbox[4];
     if (pLogFont->lfItalic) {
         flags |= PDFFONT_ITALIC;
     }
     if ((pLogFont->lfPitchAndFamily & 3) == FIXED_PITCH) {
         flags |= PDFFONT_FIXEDPITCH;
     }
     if ((pLogFont->lfPitchAndFamily & 0xf8) == FF_ROMAN) {
         flags |= PDFFONT_SERIF;
     }
     if ((pLogFont->lfPitchAndFamily & 0xf8) == FF_SCRIPT) {
         flags |= PDFFONT_SCRIPT;
     }
-    FX_BOOL bCJK = pLogFont->lfCharSet == CHINESEBIG5_CHARSET || pLogFont->lfCharSet == GB2312_CHARSET ||
+    bool bCJK = pLogFont->lfCharSet == CHINESEBIG5_CHARSET || pLogFont->lfCharSet == GB2312_CHARSET ||
                    pLogFont->lfCharSet == HANGEUL_CHARSET || pLogFont->lfCharSet == SHIFTJIS_CHARSET;
     CFX_ByteString basefont;
     if (bTranslateName && bCJK) {
         basefont = _FPDF_GetPSNameFromTT(hDC);
     }
     if (basefont.IsEmpty()) {
         basefont = pLogFont->lfFaceName;
     }
     italicangle = ptm->otmItalicAngle / 10;
     ascend = ptm->otmrcFontBox.top;
@@ skipping 259 matching lines @@
 static void _CFString2CFXByteString(CFStringRef src, CFX_ByteString &dest)
 {
     SInt32 len =  CFStringGetLength(src);
     CFRange range = CFRangeMake(0, len);
     CFIndex used = 0;
     UInt8* pBuffer = (UInt8*)calloc(len+1, sizeof(UInt8));
     CFStringGetBytes(src, range, kCFStringEncodingASCII, 0, false, pBuffer, len, &used);
     dest = (FX_CHAR*)pBuffer;
     free(pBuffer);
 }
-FX_BOOL IsHasCharSet(CFArrayRef languages, const CFX_DWordArray &charSets)
+bool IsHasCharSet(CFArrayRef languages, const CFX_DWordArray &charSets)
 {
     int iCount = charSets.GetSize();
     for (int i = 0; i < CFArrayGetCount(languages); ++i) {
         CFStringRef language = (CFStringRef)CFArrayGetValueAtIndex(languages, i);
         FX_DWORD CharSet = FX_GetCharsetFromLang(CFStringGetCStringPtr(language, kCFStringEncodingMacRoman), -1);
         for (int j = 0; j < iCount; ++j) {
             if (CharSet == charSets[j]) {
-                return TRUE;
+                return true;
             }
         }
     }
-    return FALSE;
+    return false;
 }
 void FX_GetCharWidth(CTFontRef font, UniChar start, UniChar end, int* width)
 {
     CGFloat size = CTFontGetSize(font);
     for (; start <= end; ++start) {
         CGGlyph pGlyph = 0;
         CFIndex count = 1;
         CTFontGetGlyphsForCharacters(font, &start, &pGlyph, count);
         CGSize advances;
         CTFontGetAdvancesForGlyphs(font, kCTFontDefaultOrientation, &pGlyph, &advances, 1);
@@ skipping 17 matching lines @@
         pWidthArray->AddInteger(*widths);
     } else {
         CPDF_Array* pWidthArray1 = new CPDF_Array;
         pWidthArray->Add(pWidthArray1);
         for (i = 0; i < size; i ++) {
             pWidthArray1->AddInteger(widths[i]);
         }
     }
     FX_Free(widths);
 }
-CPDF_Font* CPDF_Document::AddMacFont(CTFontRef pFont, FX_BOOL bVert, FX_BOOL bTranslateName)
+CPDF_Font* CPDF_Document::AddMacFont(CTFontRef pFont, bool bVert, bool bTranslateName)
 {
     CTFontRef font = (CTFontRef)pFont;
     CTFontDescriptorRef descriptor = CTFontCopyFontDescriptor(font);
     if (descriptor == NULL) {
         return NULL;
     }
     CFX_ByteString basefont;
-    FX_BOOL bCJK = FALSE;
+    bool bCJK = false;
     int flags = 0, italicangle = 0, ascend = 0, descend = 0, capheight = 0, bbox[4];
     FXSYS_memset(bbox, 0, sizeof(int) * 4);
     CFArrayRef languages = (CFArrayRef)CTFontDescriptorCopyAttribute(descriptor, kCTFontLanguagesAttribute);
     if (languages == NULL) {
         CFRelease(descriptor);
         return NULL;
     }
     CFX_DWordArray charSets;
     charSets.Add(FXFONT_CHINESEBIG5_CHARSET);
     charSets.Add(FXFONT_GB2312_CHARSET);
     charSets.Add(FXFONT_HANGEUL_CHARSET);
     charSets.Add(FXFONT_SHIFTJIS_CHARSET);
     if (IsHasCharSet(languages, charSets)) {
-        bCJK = TRUE;
+        bCJK = true;
     }
     CFRelease(descriptor);
     CFDictionaryRef traits = (CFDictionaryRef)CTFontCopyTraits(font);
     if (traits == NULL) {
         CFRelease(languages);
         return NULL;
     }
     CFNumberRef sybolicTrait = (CFNumberRef)CFDictionaryGetValue(traits, kCTFontSymbolicTrait);
     CTFontSymbolicTraits trait = 0;
     CFNumberGetValue(sybolicTrait, kCFNumberSInt32Type, &trait);
@@ skipping 95 matching lines @@
             pWidths->AddInteger(char_widths[i]);
         }
         pBaseDict->SetAt("Widths", pWidths);
     }  else {
         flags |= PDFFONT_NONSYMBOLIC;
         CPDF_Array* pArray = NULL;
         pFontDict = new CPDF_Dictionary;
         CFX_ByteString cmap;
         CFX_ByteString ordering;
         int supplement;
-        FX_BOOL bFound = FALSE;
+        bool bFound = false;
         CPDF_Array* pWidthArray = new CPDF_Array;
         charSets.RemoveAll();
         charSets.Add(FXFONT_CHINESEBIG5_CHARSET);
         if (IsHasCharSet(languages, charSets)) {
             cmap = bVert ? "ETenms-B5-V" : "ETenms-B5-H";
             ordering = "CNS1";
             supplement = 4;
             pWidthArray->AddInteger(1);
             _InsertWidthArray(font, 0x20, 0x7e, pWidthArray);
-            bFound = TRUE;
+            bFound = true;
         }
         charSets.RemoveAll();
         charSets.Add(FXFONT_GB2312_CHARSET);
         if (!bFound && IsHasCharSet(languages, charSets)) {
             cmap = bVert ? "GBK-EUC-V" : "GBK-EUC-H";
             ordering = "GB1", supplement = 2;
             pWidthArray->AddInteger(7716);
             _InsertWidthArray(font, 0x20, 0x20, pWidthArray);
             pWidthArray->AddInteger(814);
             _InsertWidthArray(font, 0x21, 0x7e, pWidthArray);
-            bFound = TRUE;
+            bFound = true;
         }
         charSets.RemoveAll();
         charSets.Add(FXFONT_HANGEUL_CHARSET);
         if (!bFound && IsHasCharSet(languages, charSets)) {
             cmap = bVert ? "KSCms-UHC-V" : "KSCms-UHC-H";
             ordering = "Korea1";
             supplement = 2;
             pWidthArray->AddInteger(1);
             _InsertWidthArray(font, 0x20, 0x7e, pWidthArray);
-            bFound = TRUE;
+            bFound = true;
         }
         charSets.RemoveAll();
         charSets.Add(FXFONT_SHIFTJIS_CHARSET);
         if (!bFound && IsHasCharSet(languages, charSets)) {
             cmap = bVert ? "90ms-RKSJ-V" : "90ms-RKSJ-H";
             ordering = "Japan1";
             supplement = 5;
             pWidthArray->AddInteger(231);
             _InsertWidthArray(font, 0x20, 0x7d, pWidthArray);
             pWidthArray->AddInteger(326);
@@ skipping 78 matching lines @@
         pWidthArray->AddInteger(*widths);
     } else {
         CPDF_Array* pWidthArray1 = new CPDF_Array;
         pWidthArray->Add(pWidthArray1);
         for (i = 0; i < size; i ++) {
             pWidthArray1->AddInteger(widths[i]);
         }
     }
     FX_Free(widths);
 }
-CPDF_Font* CPDF_Document::AddFont(CFX_Font* pFont, int charset, FX_BOOL bVert)
+CPDF_Font* CPDF_Document::AddFont(CFX_Font* pFont, int charset, bool bVert)
 {
     if (pFont == NULL) {
         return NULL;
     }
-    FX_BOOL bCJK = charset == FXFONT_CHINESEBIG5_CHARSET || charset == FXFONT_GB2312_CHARSET ||
+    bool bCJK = charset == FXFONT_CHINESEBIG5_CHARSET || charset == FXFONT_GB2312_CHARSET ||
                    charset == FXFONT_HANGEUL_CHARSET || charset == FXFONT_SHIFTJIS_CHARSET;
     CFX_ByteString basefont = pFont->GetFamilyName();
     basefont.Replace(" ", "");
     int flags = 0;
     if (pFont->IsBold()) {
         flags |= PDFFONT_FORCEBOLD;
     }
     if (pFont->IsItalic()) {
         flags |= PDFFONT_ITALIC;
     }
@@ skipping 159 matching lines @@
             }
         }
     }
     delete pEncoding;
     pFontDesc->SetAtInteger("StemV", nStemV);
     AddIndirectObject(pFontDesc);
     pFontDict->SetAtReference("FontDescriptor", this, pFontDesc);
     return LoadFont(pBaseDict);
 }
 static int InsertDeletePDFPage(CPDF_Document* pDoc, CPDF_Dictionary* pPages,
-                               int nPagesToGo, CPDF_Dictionary* pPage, FX_BOOL bInsert, CFX_PtrArray& stackList)
+                               int nPagesToGo, CPDF_Dictionary* pPage, bool bInsert, CFX_PtrArray& stackList)
 {
     CPDF_Array* pKidList = pPages->GetArray("Kids");
     if (!pKidList) {
         return -1;
     }
     int nKids = pKidList->GetCount();
     for (int i = 0; i < nKids; i ++) {
         CPDF_Dictionary* pKid = pKidList->GetDict(i);
         if (pKid->GetString("Type") == FX_BSTRC("Page")) {
             if (nPagesToGo == 0) {
@@ skipping 49 matching lines @@
         if (!pPagesList) {
             pPagesList = new CPDF_Array;
             pPages->SetAt(FX_BSTRC("Kids"), pPagesList);
         }
         pPagesList->Add(pPageDict, pDoc);
         pPages->SetAtInteger(FX_BSTRC("Count"), nPages + 1);
         pPageDict->SetAtReference(FX_BSTRC("Parent"), pDoc, pPages->GetObjNum());
     } else {
         CFX_PtrArray stack;
         stack.Add(pPages);
-        if (InsertDeletePDFPage(pDoc, pPages, iPage, pPageDict, TRUE, stack) < 0) {
+        if (InsertDeletePDFPage(pDoc, pPages, iPage, pPageDict, true, stack) < 0) {
             return -1;
         }
     }
     pageList.InsertAt(iPage, pPageDict->GetObjNum());
     return iPage;
 }
 CPDF_Dictionary* CPDF_Document::CreateNewPage(int iPage)
 {
     CPDF_Dictionary* pDict = new CPDF_Dictionary;
     pDict->SetAtName("Type", "Page");
@@ skipping 22 matching lines @@
     CPDF_Dictionary* pPages = pRoot->GetDict("Pages");
     if (pPages == NULL) {
         return;
     }
     int nPages = pPages->GetInteger("Count");
     if (iPage < 0 || iPage >= nPages) {
         return;
     }
     CFX_PtrArray stack;
     stack.Add(pPages);
-    if (InsertDeletePDFPage(this, pPages, iPage, NULL, FALSE, stack) < 0) {
+    if (InsertDeletePDFPage(this, pPages, iPage, NULL, false, stack) < 0) {
         return;
     }
     m_PageList.RemoveAt(iPage);
 }
 CPDF_Object* FPDFAPI_GetPageAttr(CPDF_Dictionary* pPageDict, const CFX_ByteStringC& name);
 void FPDFAPI_FlatPageAttr(CPDF_Dictionary* pPageDict, const CFX_ByteStringC& name)
 {
     if (pPageDict->KeyExist(name)) {
         return;
     }
     CPDF_Object* pObj = FPDFAPI_GetPageAttr(pPageDict, name);
     if (pObj) {
         pPageDict->SetAt(name, pObj->Clone());
     }
 }