FX Bool considered harmful, part 3

fpdfsdk/src/javascript/color.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/javascript/JavaScript.h"
 #include "../../include/javascript/IJavaScript.h"
 #include "../../include/javascript/JS_Define.h"
 #include "../../include/javascript/JS_Object.h"
@@ skipping 137 matching lines @@
         {
                 color = CPWL_Color(COLORTYPE_RGB, (FX_FLOAT)d1, (FX_FLOAT)d2, (FX_FLOAT)d3);
         }
         else if (sSpace == "CMYK")
         {
                 color = CPWL_Color(COLORTYPE_CMYK, (FX_FLOAT)d1, (FX_FLOAT)d2, (FX_FLOAT)d3, (FX_FLOAT)d4);
         }
 }
 
 #define JS_IMPLEMENT_COLORPROP(prop, var)\
-FX_BOOL color::prop(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)\
+bool color::prop(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)\
 {\
         CJS_Context* pContext = (CJS_Context*)cc;\
         v8::Isolate* isolate = pContext->GetJSRuntime()->GetIsolate();\
         if (vp.IsGetting())\
         {\
                 CJS_Array array(isolate);\
                 ConvertPWLColorToArray(var, array);\
                 vp << array;\
         }\
         else\
         {\
                 CJS_Array array(isolate);\
-                if (!vp.ConvertToArray(array)) return FALSE;\
+                if (!vp.ConvertToArray(array)) return false;\
                 ConvertArrayToPWLColor(array, var);\
         }\
-        return TRUE;\
+        return true;\
 }
 
 JS_IMPLEMENT_COLORPROP(transparent, m_crTransparent)
 JS_IMPLEMENT_COLORPROP(black, m_crBlack)
 JS_IMPLEMENT_COLORPROP(white, m_crWhite)
 JS_IMPLEMENT_COLORPROP(red, m_crRed)
 JS_IMPLEMENT_COLORPROP(green, m_crGreen)
 JS_IMPLEMENT_COLORPROP(blue, m_crBlue)
 JS_IMPLEMENT_COLORPROP(cyan, m_crCyan)
 JS_IMPLEMENT_COLORPROP(magenta, m_crMagenta)
 JS_IMPLEMENT_COLORPROP(yellow, m_crYellow)
 JS_IMPLEMENT_COLORPROP(dkGray, m_crDKGray)
 JS_IMPLEMENT_COLORPROP(gray, m_crGray)
 JS_IMPLEMENT_COLORPROP(ltGray, m_crLTGray)
 
-FX_BOOL color::convert(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool color::convert(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         v8::Isolate* isolate = GetIsolate(cc);
         int iSize = params.size();
-        if (iSize < 2) return FALSE;
+        if (iSize < 2) return false;
         CJS_Array aSource(isolate);
-        if (!params[0].ConvertToArray(aSource)) return FALSE;
+        if (!params[0].ConvertToArray(aSource)) return false;
 
         CPWL_Color crSource;
         ConvertArrayToPWLColor(aSource, crSource);
 
         CFX_ByteString sDestSpace = params[1].ToCFXByteString();
         int nColorType = COLORTYPE_TRANSPARENT;
 
         if (sDestSpace == "T")
         {
                 nColorType = COLORTYPE_TRANSPARENT;
@@ skipping 10 matching lines @@
         {
                 nColorType = COLORTYPE_CMYK;
         }
 
         CJS_Array aDest(isolate);
         CPWL_Color crDest = crSource;
         crDest.ConvertColorType(nColorType);
         ConvertPWLColorToArray(crDest, aDest);
         vRet = aDest;
 
-        return TRUE;
+        return true;
 }
 
-FX_BOOL color::equal(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
+bool color::equal(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         v8::Isolate* isolate = GetIsolate(cc);
-        if (params.size() < 2) return FALSE;
+        if (params.size() < 2) return false;
 
         CJS_Array array1(isolate), array2(isolate);
 
-        if (!params[0].ConvertToArray(array1)) return FALSE;
-        if (!params[1].ConvertToArray(array2)) return FALSE;
+        if (!params[0].ConvertToArray(array1)) return false;
+        if (!params[1].ConvertToArray(array2)) return false;
 
         CPWL_Color color1;
         CPWL_Color color2;
 
         ConvertArrayToPWLColor(array1, color1);
         ConvertArrayToPWLColor(array2, color2);
 
         color1.ConvertColorType(color2.nColorType);
 
         vRet = color1 == color2;
-        return TRUE;
+        return true;
 }