Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: core/include/fpdfapi/fpdf_page.h

Issue 1258093002: FX Bool considered harmful, part 3 (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/include/fpdfapi/fpdf_objects.h ('k') | core/include/fpdfapi/fpdf_pageobj.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/include/fpdfapi/fpdf_page.h
diff --git a/core/include/fpdfapi/fpdf_page.h b/core/include/fpdfapi/fpdf_page.h
index bd8b5c9878c677438d6590b081fc1d327c2c3067..2fc9de8566dbe6f331c97d4e9a3f0a40737f7c6f 100644
--- a/core/include/fpdfapi/fpdf_page.h
+++ b/core/include/fpdfapi/fpdf_page.h
@@ -28,12 +28,12 @@ class CPDF_StreamContentParser;
class CPDF_PageObjects
{
public:
- CPDF_PageObjects(FX_BOOL bReleaseMembers = TRUE);
+ CPDF_PageObjects(bool bReleaseMembers = true);
~CPDF_PageObjects();
void ContinueParse(IFX_Pause* pPause);
- FX_BOOL IsParsed() const
+ bool IsParsed() const
{
return m_ParseState == CONTENT_PARSED;
}
@@ -76,7 +76,7 @@ public:
void Transform(const CFX_AffineMatrix& matrix);
- FX_BOOL BackgroundAlphaNeeded() const
+ bool BackgroundAlphaNeeded() const
{
return m_bBackgroundAlphaNeeded;
}
@@ -106,8 +106,8 @@ protected:
void ClearCacheObjects();
CFX_PtrList m_ObjectList;
- FX_BOOL m_bBackgroundAlphaNeeded;
- FX_BOOL m_bReleaseMembers;
+ bool m_bBackgroundAlphaNeeded;
+ bool m_bReleaseMembers;
CPDF_ContentParser* m_pParser;
ParseState m_ParseState;
};
@@ -120,11 +120,11 @@ public:
~CPDF_Page();
- void Load(CPDF_Document* pDocument, CPDF_Dictionary* pPageDict, FX_BOOL bPageCache = TRUE);
+ void Load(CPDF_Document* pDocument, CPDF_Dictionary* pPageDict, bool bPageCache = true);
- void StartParse(CPDF_ParseOptions* pOptions = NULL, FX_BOOL bReParse = FALSE);
+ void StartParse(CPDF_ParseOptions* pOptions = NULL, bool bReParse = false);
- void ParseContent(CPDF_ParseOptions* pOptions = NULL, FX_BOOL bReParse = FALSE);
+ void ParseContent(CPDF_ParseOptions* pOptions = NULL, bool bReParse = false);
void GetDisplayMatrix(CFX_AffineMatrix& matrix, int xPos, int yPos,
int xSize, int ySize, int iRotate) const;
@@ -177,13 +177,13 @@ public:
CPDF_ParseOptions();
- FX_BOOL m_bTextOnly;
+ bool m_bTextOnly;
- FX_BOOL m_bMarkedContent;
+ bool m_bMarkedContent;
- FX_BOOL m_bSeparateForm;
+ bool m_bSeparateForm;
- FX_BOOL m_bDecodeInlineImage;
+ bool m_bDecodeInlineImage;
};
class CPDF_Form : public CPDF_PageObjects
{
@@ -206,7 +206,7 @@ class CPDF_PageContentGenerate
public:
CPDF_PageContentGenerate(CPDF_Page* pPage);
~CPDF_PageContentGenerate();
- FX_BOOL InsertPageObject(CPDF_PageObject* pPageObject);
+ bool InsertPageObject(CPDF_PageObject* pPageObject);
void GenerateContent();
void TransformContent(CFX_Matrix& matrix);
protected:
« no previous file with comments | « core/include/fpdfapi/fpdf_objects.h ('k') | core/include/fpdfapi/fpdf_pageobj.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698