FX Bool considered harmful, part 3

fpdfsdk/src/javascript/JS_Value.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/javascript/JavaScript.h"
 #include "../../include/javascript/JS_Define.h"
 #include "../../include/javascript/JS_Object.h"
 #include "../../include/javascript/JS_Value.h"
@@ skipping 238 matching lines @@
         if(m_pValue->IsString()) return VT_string;
         if(m_pValue->IsNumber()) return VT_number;
         if(m_pValue->IsBoolean()) return VT_boolean;
         if(m_pValue->IsDate()) return VT_date;
         if(m_pValue->IsObject()) return VT_object;
         if(m_pValue->IsNull()) return VT_null;
         if(m_pValue->IsUndefined()) return VT_undefined;
         return VT_unknown;
 }
 
-FX_BOOL CJS_Value::IsArrayObject() const
+bool CJS_Value::IsArrayObject() const
 {
-        if(m_pValue.IsEmpty()) return FALSE;
+        if(m_pValue.IsEmpty()) return false;
         return m_pValue->IsArray();
 }
 
-FX_BOOL CJS_Value::IsDateObject() const
+bool CJS_Value::IsDateObject() const
 {
-        if(m_pValue.IsEmpty()) return FALSE;
+        if(m_pValue.IsEmpty()) return false;
         return m_pValue->IsDate();
 }
 
 //CJS_Value::operator CJS_Array()
-FX_BOOL CJS_Value::ConvertToArray(CJS_Array &array) const
+bool CJS_Value::ConvertToArray(CJS_Array &array) const
 {
         if (IsArrayObject())
         {
                 array.Attach(JS_ToArray(m_isolate, m_pValue));
-                return TRUE;
+                return true;
         }
 
-        return FALSE;
+        return false;
 }
 
-FX_BOOL CJS_Value::ConvertToDate(CJS_Date &date) const
+bool CJS_Value::ConvertToDate(CJS_Date &date) const
 {
 //      if (GetType() == VT_date)
 //      {
 //              date = (double)(*this);
-//              return TRUE;
+//              return true;
 //      }
 
         if (IsDateObject())
         {
                 date.Attach(m_pValue);
-                return TRUE;
+                return true;
         }
 
-        return FALSE;
+        return false;
 }
 
 /* ---------------------------- CJS_PropValue ---------------------------- */
 
 CJS_PropValue::CJS_PropValue(const CJS_Value &value) :
         CJS_Value(value),
         m_bIsSetting(0)
 {
 }
 
 CJS_PropValue::CJS_PropValue(v8::Isolate* isolate) : CJS_Value(isolate),
                                  m_bIsSetting(0)
 {
 }
 
 CJS_PropValue::~CJS_PropValue()
 {
 }
 
-FX_BOOL CJS_PropValue::IsSetting()
+bool CJS_PropValue::IsSetting()
 {
         return m_bIsSetting;
 }
 
-FX_BOOL CJS_PropValue::IsGetting()
+bool CJS_PropValue::IsGetting()
 {
         return !m_bIsSetting;
 }
 
 void CJS_PropValue::operator <<(int iValue)
 {
         ASSERT(!m_bIsSetting);
         CJS_Value::operator =(iValue);
 }
 
@@ skipping 140 matching lines @@
 
 CJS_Array::~CJS_Array()
 {
 }
 
 void CJS_Array::Attach(v8::Local<v8::Array> pArray)
 {
         m_pArray = pArray;
 }
 
-FX_BOOL CJS_Array::IsAttached()
+bool CJS_Array::IsAttached()
 {
-        return FALSE;
+        return false;
 }
 
 void CJS_Array::GetElement(unsigned index,CJS_Value &value)
 {
         if (m_pArray.IsEmpty())
                 return;
         v8::Local<v8::Value>  p = JS_GetArrayElement(m_isolate, m_pArray,index);
         value.Attach(p,VT_object);
 }
 
@@ skipping 40 matching lines @@
 
 double CJS_Date::MakeDate(int year, int mon, int day,int hour, int min, int sec,int ms)
 {
         return JS_MakeDate(JS_MakeDay(year,mon,day), JS_MakeTime(hour,min,sec,ms));
 }
 
 CJS_Date::~CJS_Date()
 {
 }
 
-FX_BOOL CJS_Date::IsValidDate()
+bool    CJS_Date::IsValidDate()
 {
-        if(m_pDate.IsEmpty()) return FALSE;
+        if(m_pDate.IsEmpty()) return false;
         return !JS_PortIsNan(JS_ToNumber(m_isolate, m_pDate));
 }
 
 void CJS_Date::Attach(v8::Local<v8::Value> pDate)
 {
         m_pDate = pDate;
 }
 
 int CJS_Date::GetYear()
 {
@@ skipping 94 matching lines @@
                 return 0.0;
         return JS_ToNumber(m_isolate, m_pDate);
 }
 
 CFX_WideString CJS_Date::ToString() const
 {
         if(m_pDate.IsEmpty())
                 return L"";
         return JS_ToString(m_isolate, m_pDate);
 }