Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1219063013: Fix virtual/override/final usage in Source/core/dom/. (Closed)

Created:
5 years, 5 months ago by tkent
Modified:
5 years, 5 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix virtual/override/final usage in Source/core/dom/. - We should specify just one of them to a function. - Non-base virtual destructors should have |override| keywords. This CL has no behavior changes. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198371

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -274 lines) Patch
M Source/core/dom/Attr.h View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/dom/CDATASection.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/CharacterData.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/ChildNodeList.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/ClassCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Comment.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/ContainerNode.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/CrossThreadTask.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMArrayBuffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DOMArrayBufferView.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DOMDataView.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DOMDataView.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/DOMSettableTokenList.h View 2 chunks +12 lines, -12 lines 0 comments Download
M Source/core/dom/DOMTypedArray.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DOMURL.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/DOMURLUtils.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DatasetDOMStringMap.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/dom/DecodedDataDocumentParser.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/dom/Document.h View 13 chunks +37 lines, -37 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentFragment.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/dom/DocumentMarker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentType.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/dom/Element.h View 10 chunks +17 lines, -17 lines 0 comments Download
M Source/core/dom/EmptyNodeList.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/ExecutionContextTask.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/FirstLetterPseudoElement.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Fullscreen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/LiveNodeList.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/MainThreadTaskRunnerTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/MessagePort.h View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/dom/MutationRecord.cpp View 5 chunks +24 lines, -24 lines 0 comments Download
M Source/core/dom/NameNodeList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Node.h View 5 chunks +12 lines, -12 lines 0 comments Download
M Source/core/dom/ProcessingInstruction.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/dom/PseudoElement.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/RawDataDocumentParser.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/ScriptLoader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ScriptableDocumentParser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StaticNodeList.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/StringCallback.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/StyleEngine.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TagCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TemplateContentDocumentFragment.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Text.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/custom/CustomElementAsyncImportMicrotaskQueue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementCallbackInvocation.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskImportStep.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskResolutionStep.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/custom/CustomElementUpgradeCandidateMap.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/shadow/InsertionPoint.h View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.h View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
yosin@, please review this.
5 years, 5 months ago (2015-07-07 06:17:16 UTC) #2
yosin_UTC9
lgtm This patch is done by sed for virtual member functions and grep and manual ...
5 years, 5 months ago (2015-07-07 07:12:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219063013/1
5 years, 5 months ago (2015-07-07 07:13:06 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 08:13:33 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198371

Powered by Google App Engine
This is Rietveld 408576698