Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Unified Diff: Source/core/dom/MessagePort.h

Issue 1219063013: Fix virtual/override/final usage in Source/core/dom/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/MainThreadTaskRunnerTest.cpp ('k') | Source/core/dom/MutationRecord.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/MessagePort.h
diff --git a/Source/core/dom/MessagePort.h b/Source/core/dom/MessagePort.h
index 6885664a8aaee1d2ce4ab9e60de6340bf0966934..f9659e7967296fafc098c0d06089a347ee321ac4 100644
--- a/Source/core/dom/MessagePort.h
+++ b/Source/core/dom/MessagePort.h
@@ -65,7 +65,7 @@ class CORE_EXPORT MessagePort
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MessagePort);
public:
static PassRefPtrWillBeRawPtr<MessagePort> create(ExecutionContext&);
- virtual ~MessagePort();
+ ~MessagePort() override;
void postMessage(ExecutionContext*, PassRefPtr<SerializedScriptValue> message, const MessagePortArray*, ExceptionState&);
@@ -86,13 +86,13 @@ public:
bool started() const { return m_started; }
- virtual const AtomicString& interfaceName() const override;
- virtual ExecutionContext* executionContext() const override { return ActiveDOMObject::executionContext(); }
- virtual MessagePort* toMessagePort() override { return this; }
+ const AtomicString& interfaceName() const override;
+ ExecutionContext* executionContext() const override { return ActiveDOMObject::executionContext(); }
+ MessagePort* toMessagePort() override { return this; }
// ActiveDOMObject implementation.
- virtual bool hasPendingActivity() const override;
- virtual void stop() override { close(); }
+ bool hasPendingActivity() const override;
+ void stop() override { close(); }
void setOnmessage(PassRefPtr<EventListener> listener)
{
@@ -115,9 +115,9 @@ protected:
private:
// WebMessagePortChannelClient implementation.
- virtual void messageAvailable() override;
- virtual v8::Isolate* scriptIsolate() override;
- virtual v8::Local<v8::Context> scriptContextForMessageConversion() override;
+ void messageAvailable() override;
+ v8::Isolate* scriptIsolate() override;
+ v8::Local<v8::Context> scriptContextForMessageConversion() override;
void dispatchMessages();
OwnPtr<WebMessagePortChannel> m_entangledChannel;
« no previous file with comments | « Source/core/dom/MainThreadTaskRunnerTest.cpp ('k') | Source/core/dom/MutationRecord.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698