Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: Source/core/dom/DecodedDataDocumentParser.h

Issue 1219063013: Fix virtual/override/final usage in Source/core/dom/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/DatasetDOMStringMap.h ('k') | Source/core/dom/Document.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google, Inc. All Rights Reserved. 2 * Copyright (C) 2010 Google, Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 21 matching lines...) Expand all
32 namespace blink { 32 namespace blink {
33 class TextResourceDecoder; 33 class TextResourceDecoder;
34 34
35 class DecodedDataDocumentParser : public DocumentParser { 35 class DecodedDataDocumentParser : public DocumentParser {
36 public: 36 public:
37 // Only used by the XMLDocumentParser to communicate back to 37 // Only used by the XMLDocumentParser to communicate back to
38 // XMLHttpRequest if the responseXML was well formed. 38 // XMLHttpRequest if the responseXML was well formed.
39 virtual bool wellFormed() const { return true; } 39 virtual bool wellFormed() const { return true; }
40 40
41 // The below functions are used by DocumentWriter (the loader). 41 // The below functions are used by DocumentWriter (the loader).
42 virtual void appendBytes(const char* bytes, size_t length) override; 42 void appendBytes(const char* bytes, size_t length) override;
43 virtual void flush() override; 43 void flush() override;
44 virtual bool needsDecoder() const override final { return m_needsDecoder; } 44 bool needsDecoder() const final { return m_needsDecoder; }
45 virtual void setDecoder(PassOwnPtr<TextResourceDecoder>) override; 45 void setDecoder(PassOwnPtr<TextResourceDecoder>) override;
46 virtual TextResourceDecoder* decoder() override final; 46 TextResourceDecoder* decoder() final;
47 47
48 PassOwnPtr<TextResourceDecoder> takeDecoder(); 48 PassOwnPtr<TextResourceDecoder> takeDecoder();
49 49
50 protected: 50 protected:
51 explicit DecodedDataDocumentParser(Document&); 51 explicit DecodedDataDocumentParser(Document&);
52 virtual ~DecodedDataDocumentParser(); 52 ~DecodedDataDocumentParser() override;
53 53
54 private: 54 private:
55 void updateDocument(String& decodedData); 55 void updateDocument(String& decodedData);
56 56
57 bool m_needsDecoder; 57 bool m_needsDecoder;
58 OwnPtr<TextResourceDecoder> m_decoder; 58 OwnPtr<TextResourceDecoder> m_decoder;
59 }; 59 };
60 60
61 } 61 }
62 62
63 #endif // DecodedDataDocumentParser_h 63 #endif // DecodedDataDocumentParser_h
OLDNEW
« no previous file with comments | « Source/core/dom/DatasetDOMStringMap.h ('k') | Source/core/dom/Document.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698