Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: Source/core/dom/ExecutionContextTask.h

Issue 1219063013: Fix virtual/override/final usage in Source/core/dom/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/EmptyNodeList.h ('k') | Source/core/dom/FirstLetterPseudoElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Neither the name of Google Inc. nor the names of its 10 * * Neither the name of Google Inc. nor the names of its
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 class CallClosureTask final : public CallClosureTaskBase<void()> { 83 class CallClosureTask final : public CallClosureTaskBase<void()> {
84 public: 84 public:
85 // Do not use |create| other than in createCrossThreadTask and 85 // Do not use |create| other than in createCrossThreadTask and
86 // createSameThreadTask. 86 // createSameThreadTask.
87 // See http://crbug.com/390851 87 // See http://crbug.com/390851
88 static PassOwnPtr<CallClosureTask> create(PassOwnPtr<Closure> closure, bool isSameThread = false) 88 static PassOwnPtr<CallClosureTask> create(PassOwnPtr<Closure> closure, bool isSameThread = false)
89 { 89 {
90 return adoptPtr(new CallClosureTask(closure, isSameThread)); 90 return adoptPtr(new CallClosureTask(closure, isSameThread));
91 } 91 }
92 92
93 virtual void performTask(ExecutionContext*) override 93 void performTask(ExecutionContext*) override
94 { 94 {
95 checkThread(); 95 checkThread();
96 (*m_closure)(); 96 (*m_closure)();
97 } 97 }
98 98
99 private: 99 private:
100 CallClosureTask(PassOwnPtr<Closure> closure, bool isSameThread) 100 CallClosureTask(PassOwnPtr<Closure> closure, bool isSameThread)
101 : CallClosureTaskBase<void()>(closure, isSameThread) 101 : CallClosureTaskBase<void()>(closure, isSameThread)
102 { 102 {
103 } 103 }
104 }; 104 };
105 105
106 } // namespace internal 106 } // namespace internal
107 107
108 // Create tasks passed within a single thread. 108 // Create tasks passed within a single thread.
109 // When posting tasks within a thread, use |createSameThreadTask| instead 109 // When posting tasks within a thread, use |createSameThreadTask| instead
110 // of using |bind| directly to state explicitly that there is no need to care 110 // of using |bind| directly to state explicitly that there is no need to care
111 // about thread safety when posting the task. 111 // about thread safety when posting the task.
112 // When posting tasks across threads, use |createCrossThreadTask|. 112 // When posting tasks across threads, use |createCrossThreadTask|.
113 template<typename FunctionType, typename... P> 113 template<typename FunctionType, typename... P>
114 PassOwnPtr<ExecutionContextTask> createSameThreadTask( 114 PassOwnPtr<ExecutionContextTask> createSameThreadTask(
115 FunctionType function, const P&... parameters) 115 FunctionType function, const P&... parameters)
116 { 116 {
117 return internal::CallClosureTask::create(bind(function, parameters...), true ); 117 return internal::CallClosureTask::create(bind(function, parameters...), true );
118 } 118 }
119 119
120 } // namespace 120 } // namespace
121 121
122 #endif 122 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/EmptyNodeList.h ('k') | Source/core/dom/FirstLetterPseudoElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698