Source/core/dom/custom/CustomElementCallbackInvocation.cpp - Issue 1219063013: Fix virtual/override/final usage in Source/core/dom/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/custom/CustomElementCallbackInvocation.cpp

Issue 1219063013: Fix virtual/override/final usage in Source/core/dom/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/dom/custom/CustomElementAsyncImportMicrotaskQueue.h ('k') | Source/core/dom/custom/CustomElementMicrotaskImportStep.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/custom/CustomElementCallbackInvocation.cpp

diff --git a/Source/core/dom/custom/CustomElementCallbackInvocation.cpp b/Source/core/dom/custom/CustomElementCallbackInvocation.cpp

index 90280cfee91f771fcc77cf0ab1e04b30a9c39a4c..a219b056cfd7eddfbe1f7f8773e16f9f55cc4993 100644

--- a/Source/core/dom/custom/CustomElementCallbackInvocation.cpp

+++ b/Source/core/dom/custom/CustomElementCallbackInvocation.cpp

@@ -42,7 +42,7 @@ public:

AttachedDetachedInvocation(PassRefPtrWillBeRawPtr<CustomElementLifecycleCallbacks>, CustomElementLifecycleCallbacks::CallbackType which);

private:

- virtual void dispatch(Element*) override;

+ void dispatch(Element*) override;

CustomElementLifecycleCallbacks::CallbackType m_which;

};

@@ -73,7 +73,7 @@ public:

AttributeChangedInvocation(PassRefPtrWillBeRawPtr<CustomElementLifecycleCallbacks>, const AtomicString& name, const AtomicString& oldValue, const AtomicString& newValue);

private:

- virtual void dispatch(Element*) override;

+ void dispatch(Element*) override;

AtomicString m_name;

AtomicString m_oldValue;

@@ -101,8 +101,8 @@ public:

}

private:

- virtual void dispatch(Element*) override;

- virtual bool isCreatedCallback() const override { return true; }

+ void dispatch(Element*) override;

+ bool isCreatedCallback() const override { return true; }

};

void CreatedInvocation::dispatch(Element* element)