Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: Source/core/dom/CharacterData.h

Issue 1219063013: Fix virtual/override/final usage in Source/core/dom/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/CDATASection.h ('k') | Source/core/dom/ChildNodeList.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009 Apple Inc. All rights reserv ed. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009 Apple Inc. All rights reserv ed.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 } 67 }
68 enum UpdateSource { 68 enum UpdateSource {
69 UpdateFromParser, 69 UpdateFromParser,
70 UpdateFromNonParser, 70 UpdateFromNonParser,
71 }; 71 };
72 void didModifyData(const String& oldValue, UpdateSource); 72 void didModifyData(const String& oldValue, UpdateSource);
73 73
74 String m_data; 74 String m_data;
75 75
76 private: 76 private:
77 virtual String nodeValue() const override final; 77 String nodeValue() const final;
78 virtual void setNodeValue(const String&) override final; 78 void setNodeValue(const String&) final;
79 virtual bool isCharacterDataNode() const override final { return true; } 79 bool isCharacterDataNode() const final { return true; }
80 virtual int maxCharacterOffset() const override final; 80 int maxCharacterOffset() const final;
81 void setDataAndUpdate(const String&, unsigned offsetOfReplacedData, unsigned oldLength, unsigned newLength, UpdateSource = UpdateFromNonParser, RecalcStyleB ehavior = DoNotRecalcStyle); 81 void setDataAndUpdate(const String&, unsigned offsetOfReplacedData, unsigned oldLength, unsigned newLength, UpdateSource = UpdateFromNonParser, RecalcStyleB ehavior = DoNotRecalcStyle);
82 82
83 bool isContainerNode() const = delete; // This will catch anyone doing an un necessary check. 83 bool isContainerNode() const = delete; // This will catch anyone doing an un necessary check.
84 bool isElementNode() const = delete; // This will catch anyone doing an unne cessary check. 84 bool isElementNode() const = delete; // This will catch anyone doing an unne cessary check.
85 }; 85 };
86 86
87 DEFINE_NODE_TYPE_CASTS(CharacterData, isCharacterDataNode()); 87 DEFINE_NODE_TYPE_CASTS(CharacterData, isCharacterDataNode());
88 88
89 } // namespace blink 89 } // namespace blink
90 90
91 #endif // CharacterData_h 91 #endif // CharacterData_h
OLDNEW
« no previous file with comments | « Source/core/dom/CDATASection.h ('k') | Source/core/dom/ChildNodeList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698