Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Unified Diff: Source/core/dom/Text.h

Issue 1219063013: Fix virtual/override/final usage in Source/core/dom/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Text.h
diff --git a/Source/core/dom/Text.h b/Source/core/dom/Text.h
index 5c54a2a3d08c3b682156605a78f7bc0367ce000e..08178b7bf70414c2eb30313fb738aac86e5e1ee7 100644
--- a/Source/core/dom/Text.h
+++ b/Source/core/dom/Text.h
@@ -56,11 +56,11 @@ public:
LayoutText* createTextLayoutObject(const ComputedStyle&);
void updateTextLayoutObject(unsigned offsetOfReplacedData, unsigned lengthOfReplacedData, RecalcStyleBehavior = DoNotRecalcStyle);
- virtual void attach(const AttachContext& = AttachContext()) override final;
+ void attach(const AttachContext& = AttachContext()) final;
void reattachIfNeeded(const AttachContext& = AttachContext());
- virtual bool canContainRangeEndPoint() const override final { return true; }
- virtual NodeType nodeType() const override;
+ bool canContainRangeEndPoint() const final { return true; }
+ NodeType nodeType() const override;
DECLARE_VIRTUAL_TRACE();
@@ -69,8 +69,8 @@ protected:
: CharacterData(treeScope, data, type) { }
private:
- virtual String nodeName() const override;
- virtual PassRefPtrWillBeRawPtr<Node> cloneNode(bool deep = true) override final;
+ String nodeName() const override;
+ PassRefPtrWillBeRawPtr<Node> cloneNode(bool deep = true) final;
bool isTextNode() const = delete; // This will catch anyone doing an unnecessary check.
@@ -79,7 +79,7 @@ private:
virtual PassRefPtrWillBeRawPtr<Text> cloneWithData(const String&);
#ifndef NDEBUG
- virtual void formatForDebugger(char* buffer, unsigned length) const override;
+ void formatForDebugger(char* buffer, unsigned length) const override;
#endif
};
« no previous file with comments | « Source/core/dom/TemplateContentDocumentFragment.h ('k') | Source/core/dom/custom/CustomElementAsyncImportMicrotaskQueue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698