Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: Source/core/dom/shadow/ShadowRoot.h

Issue 1219063013: Fix virtual/override/final usage in Source/core/dom/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/shadow/InsertionPoint.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/shadow/ShadowRoot.h
diff --git a/Source/core/dom/shadow/ShadowRoot.h b/Source/core/dom/shadow/ShadowRoot.h
index b2cc4b44bb9eb35464c8ce9ef5dae29608d6438b..6d2666766963ab0daab9ea2bf7d2b210cc8e3dad 100644
--- a/Source/core/dom/shadow/ShadowRoot.h
+++ b/Source/core/dom/shadow/ShadowRoot.h
@@ -79,10 +79,10 @@ public:
bool isYoungest() const { return !youngerShadowRoot(); }
bool isOldest() const { return !olderShadowRoot(); }
- virtual void attach(const AttachContext& = AttachContext()) override;
+ void attach(const AttachContext& = AttachContext()) override;
- virtual InsertionNotificationRequest insertedInto(ContainerNode*) override;
- virtual void removedFrom(ContainerNode*) override;
+ InsertionNotificationRequest insertedInto(ContainerNode*) override;
+ void removedFrom(ContainerNode*) override;
void registerScopedHTMLStyleChild();
void unregisterScopedHTMLStyleChild();
@@ -131,13 +131,13 @@ public:
private:
ShadowRoot(Document&, ShadowRootType);
- virtual ~ShadowRoot();
+ ~ShadowRoot() override;
#if !ENABLE(OILPAN)
- virtual void dispose() override;
+ void dispose() override;
#endif
- virtual void childrenChanged(const ChildrenChange&) override;
+ void childrenChanged(const ChildrenChange&) override;
ShadowRootRareData* ensureShadowRootRareData();
@@ -146,7 +146,7 @@ private:
void invalidateDescendantInsertionPoints();
// ShadowRoots should never be cloned.
- virtual PassRefPtrWillBeRawPtr<Node> cloneNode(bool) override { return nullptr; }
+ PassRefPtrWillBeRawPtr<Node> cloneNode(bool) override { return nullptr; }
// FIXME: This shouldn't happen. https://bugs.webkit.org/show_bug.cgi?id=88834
bool isOrphan() const { return !host(); }
« no previous file with comments | « Source/core/dom/shadow/InsertionPoint.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698