Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: Source/core/dom/Attr.h

Issue 1219063013: Fix virtual/override/final usage in Source/core/dom/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/dom/CDATASection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Attr.h
diff --git a/Source/core/dom/Attr.h b/Source/core/dom/Attr.h
index 18d44adb48a41bb22cc510afbf3d5dcc42241b04..6648b67f4e217ab0ae73e784a80e7b1a88fde522 100644
--- a/Source/core/dom/Attr.h
+++ b/Source/core/dom/Attr.h
@@ -36,7 +36,7 @@ class CORE_EXPORT Attr final : public Node {
public:
static PassRefPtrWillBeRawPtr<Attr> create(Element&, const QualifiedName&);
static PassRefPtrWillBeRawPtr<Attr> create(Document&, const QualifiedName&, const AtomicString& value);
- virtual ~Attr();
+ ~Attr() override;
String name() const { return m_name.toString(); }
bool specified() const { return true; }
@@ -53,8 +53,8 @@ public:
void attachToElement(Element*, const AtomicString&);
void detachFromElementWithValue(const AtomicString&);
- virtual const AtomicString& localName() const override { return m_name.localName(); }
- virtual const AtomicString& namespaceURI() const override { return m_name.namespaceURI(); }
+ const AtomicString& localName() const override { return m_name.localName(); }
+ const AtomicString& namespaceURI() const override { return m_name.namespaceURI(); }
const AtomicString& prefix() const { return m_name.prefix(); }
DECLARE_VIRTUAL_TRACE();
@@ -65,14 +65,14 @@ private:
bool isElementNode() const = delete; // This will catch anyone doing an unnecessary check.
- virtual String nodeName() const override { return name(); }
- virtual NodeType nodeType() const override { return ATTRIBUTE_NODE; }
+ String nodeName() const override { return name(); }
+ NodeType nodeType() const override { return ATTRIBUTE_NODE; }
- virtual String nodeValue() const override { return value(); }
- virtual void setNodeValue(const String&) override;
- virtual PassRefPtrWillBeRawPtr<Node> cloneNode(bool deep = true) override;
+ String nodeValue() const override { return value(); }
+ void setNodeValue(const String&) override;
+ PassRefPtrWillBeRawPtr<Node> cloneNode(bool deep = true) override;
- virtual bool isAttributeNode() const override { return true; }
+ bool isAttributeNode() const override { return true; }
// Attr wraps either an element/name, or a name/value pair (when it's a standalone Node.)
// Note that m_name is always set, but m_element/m_standaloneValue may be null.
« no previous file with comments | « no previous file | Source/core/dom/CDATASection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698