Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1200053004: Move more string_util functions to base namespace. (Closed)

Created:
5 years, 6 months ago by brettw
Modified:
5 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, asanka, aboxhall+watch_chromium.org, skanuj+watch_chromium.org, zea+watch_chromium.org, tzik, dhollowa+watch_chromium.org, dougw+watch_chromium.org, maxbogue+watch_chromium.org, browser-components-watch_chromium.org, scheib+watch_chromium.org, dmazzoni+watch_chromium.org, markusheintz_, stevenjb+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, Matt Giuca, benjhayden+dwatch_chromium.org, jdduke+watch_chromium.org, maniscalco+watch_chromium.org, tdresser+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, je_julie, darin-cc_chromium.org, rouslan+autofillwatch_chromium.org, erikwright (departed), chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, vabr+watchlist_chromium.org, mlamouri+watch-content_chromium.org, dtseng+watch_chromium.org, tapted, nhiroki, feature-media-reviews_chromium.org, jfweitz+watch_chromium.org, yuzo+watch_chromium.org, oshima+watch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, mlamouri+watch-manifest_chromium.org, Jered, mkwst+watchlist-passwords_chromium.org, michaeln, kalyank, plundblad+watch_chromium.org, tfarina, donnd+watch_chromium.org, nektar+watch_chromium.org, ozone-reviews_chromium.org, plaree+watch_chromium.org, David Black, davemoore+watch_chromium.org, samarth+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, kmadhusu+watch_chromium.org, kinuko+fileapi, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move more string_util functions to base namespace. Rename IsWhitespace to IsUnicodeWhitespace (to contrast it to the already-existing IsAsciiWhitespace). De-inline HexDigitToInt. This is only used in a few places and I don't think it's necessary to inline. Remove some redundant base:: qualifications in base. TBR=sky Committed: https://crrev.com/b3413064f36bf166d7dffb463bc442059dab1dd7 Cr-Commit-Position: refs/heads/master@{#335827}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -156 lines) Patch
M base/json/json_parser.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M base/process/internal_linux.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/strings/string_number_conversions.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M base/strings/string_util.h View 3 chunks +19 lines, -24 lines 0 comments Download
M base/strings/string_util.cc View 1 2 3 chunks +14 lines, -3 lines 0 comments Download
M base/test/expectations/parser.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/install_signer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/install_verification/win/module_ids.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/internal_auth.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profile_resetter/jtl_foundation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/search/search_ipc_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/favicon/fallback_icon_url_parser.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/validation.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/common/save_password_progress_logger.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/content_settings/core/common/content_settings_pattern_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/gcm_driver/instance_id/instance_id_driver_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/omnibox/history_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/scored_history_match.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/affiliation_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/browser_save_password_progress_logger.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/resource_provider/file_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/search_engines/template_url_parser.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/translate/core/language_detection/language_detection_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/url_fixer/url_fixer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/appcache/view_appcache_internals_job.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/download/save_package.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/save_package_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/file_system_dir_url_request_job_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/android/address_parser_internal.cc View 10 chunks +11 lines, -11 lines 0 comments Download
M content/renderer/manifest/manifest_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_uuid.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/udev_linux/udev.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/networking_config/networking_config_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/vpn_provider/vpn_provider_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/user_script_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/csp_validator.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/message_bundle.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/permissions/socket_permission_entry.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/oauth_request_signer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/base/mime_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M media/blink/webcontentdecryptionmodulesession_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/data_url.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/escape.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/base/mime_sniffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_util_icu.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cookies/cookie_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_content_disposition.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/http/http_security_headers.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/tools/dump_cache/url_to_filename_encoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/dump_cache/url_utilities.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/lib/rlz_lib.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/win/lib/machine_deal.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/database/database_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/util/get_session_name_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/command_args.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/filesystem_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/label.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/label_pattern.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/tokenizer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/tokenizer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/accessibility/ax_text_utils.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/app_list/search/term_break_iterator.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/accelerators/accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_feedback.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (10 generated)
brettw
5 years, 6 months ago (2015-06-22 23:16:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200053004/40001
5 years, 6 months ago (2015-06-22 23:17:39 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/65705)
5 years, 6 months ago (2015-06-22 23:47:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200053004/40001
5 years, 6 months ago (2015-06-23 00:22:45 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/66283)
5 years, 6 months ago (2015-06-23 00:43:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200053004/40001
5 years, 6 months ago (2015-06-23 19:23:24 UTC) #12
commit-bot: I haz the power
Exceeded global retry quota
5 years, 6 months ago (2015-06-23 19:53:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200053004/60001
5 years, 6 months ago (2015-06-23 21:14:13 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/23533)
5 years, 6 months ago (2015-06-23 22:45:33 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200053004/60001
5 years, 6 months ago (2015-06-23 23:57:13 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-24 00:39:16 UTC) #21
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 00:40:15 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b3413064f36bf166d7dffb463bc442059dab1dd7
Cr-Commit-Position: refs/heads/master@{#335827}

Powered by Google App Engine
This is Rietveld 408576698