components/content_settings/core/common/content_settings_pattern_parser.cc - Issue 1200053004: Move more string_util functions to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/common/content_settings_pattern_parser.cc

Issue 1200053004: Move more string_util functions to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/common/save_password_progress_logger.cc ('k') | components/gcm_driver/instance_id/instance_id_driver_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/common/content_settings_pattern_parser.cc

diff --git a/components/content_settings/core/common/content_settings_pattern_parser.cc b/components/content_settings/core/common/content_settings_pattern_parser.cc

index ae7dcc3e1901a6fa46dd5d9e093ef9bbe010f1ef..cbdd260ead66c01bec9f345f7c8fb155040ac2ef 100644

--- a/components/content_settings/core/common/content_settings_pattern_parser.cc

+++ b/components/content_settings/core/common/content_settings_pattern_parser.cc

@@ -152,7 +152,7 @@ void PatternParser::Parse(const std::string& pattern_spec,

} else {

// Check if the port string represents a valid port.

for (size_t i = 0; i < port.size(); ++i) {

- if (!IsAsciiDigit(port[i])) {

+ if (!base::IsAsciiDigit(port[i])) {

builder->Invalid();

return;

}