extensions/common/message_bundle.cc - Issue 1200053004: Move more string_util functions to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/message_bundle.cc

Issue 1200053004: Move more string_util functions to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/message_bundle.cc

diff --git a/extensions/common/message_bundle.cc b/extensions/common/message_bundle.cc

index 1340e549935fade3a68f2e70dcdeac801982974e..d71513ff5affc80a8eb52114003a4c80f1ffff22 100644

--- a/extensions/common/message_bundle.cc

+++ b/extensions/common/message_bundle.cc

@@ -281,7 +281,8 @@ bool MessageBundle::IsValidName(const std::string& name) {

std::string::const_iterator it = name.begin();

for (; it != name.end(); ++it) {

// Allow only ascii 0-9, a-z, A-Z, and _ in the name.

- if (!IsAsciiAlpha(*it) && !IsAsciiDigit(*it) && *it != '_' && *it != '@')

+ if (!base::IsAsciiAlpha(*it) && !base::IsAsciiDigit(*it) && *it != '_' &&

+ *it != '@')

return false;

}