net/base/net_util.cc - Issue 1200053004: Move more string_util functions to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/net_util.cc

Issue 1200053004: Move more string_util functions to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/net_util.cc

diff --git a/net/base/net_util.cc b/net/base/net_util.cc

index ebd2bf3958077d09ab2e56e0a5f58fc05e6dc722..c59b3cd7ff4e91e1468ae5ca13a3c8110cc07882 100644

--- a/net/base/net_util.cc

+++ b/net/base/net_util.cc

@@ -341,7 +341,7 @@ void SetExplicitlyAllowedPorts(const std::string& allowed_ports) {

// Overflow is still possible for evil user inputs.

for (size_t i = 0; i <= size; ++i) {

// The string should be composed of only digits and commas.

- if (i != size && !IsAsciiDigit(allowed_ports[i]) &&

+ if (i != size && !base::IsAsciiDigit(allowed_ports[i]) &&

(allowed_ports[i] != kComma))

return;

if (i == size || allowed_ports[i] == kComma) {

« no previous file with comments | « net/base/mime_sniffer.cc ('k') | net/base/net_util_icu.cc » ('j') | no next file with comments »