content/browser/fileapi/file_system_dir_url_request_job_unittest.cc - Issue 1200053004: Move more string_util functions to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/fileapi/file_system_dir_url_request_job_unittest.cc

Issue 1200053004: Move more string_util functions to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/download/save_package_unittest.cc ('k') | content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/fileapi/file_system_dir_url_request_job_unittest.cc

diff --git a/content/browser/fileapi/file_system_dir_url_request_job_unittest.cc b/content/browser/fileapi/file_system_dir_url_request_job_unittest.cc

index 43dd81295c16e25a006227398b6af09c5a7371e4..e02027be26cc0c899accb1acbd95e87a248c0f70 100644

--- a/content/browser/fileapi/file_system_dir_url_request_job_unittest.cc

+++ b/content/browser/fileapi/file_system_dir_url_request_job_unittest.cc

@@ -265,7 +265,8 @@ class FileSystemDirURLRequestJobTest : public testing::Test {

EXPECT_EQ(icu::UnicodeString(is_directory ? "1" : "0"),

match.group(3, status));

if (size >= 0) {

- icu::UnicodeString size_string(FormatBytesUnlocalized(size).c_str());

+ icu::UnicodeString size_string(

+ base::FormatBytesUnlocalized(size).c_str());

EXPECT_EQ(size_string, match.group(4, status));

}