content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc - Issue 1200053004: Move more string_util functions to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc

Issue 1200053004: Move more string_util functions to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/fileapi/file_system_dir_url_request_job_unittest.cc ('k') | content/common/android/address_parser_internal.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc

diff --git a/content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc b/content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc

index d5f1da50f8643f5d887ce1af076e0ff1651b0c17..bdb2514007043e0d33c2d878fd72beda0ad9965f 100644

--- a/content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc

+++ b/content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc

@@ -498,8 +498,8 @@ std::string PepperFileSystemBrowserHost::GeneratePluginId(

// Verify |output| contains only alphabets, digits, or "._-".

for (std::string::const_iterator it = output.begin(); it != output.end();

++it) {

- if (!IsAsciiAlpha(*it) && !IsAsciiDigit(*it) && *it != '.' && *it != '_' &&

- *it != '-') {

+ if (!base::IsAsciiAlpha(*it) && !base::IsAsciiDigit(*it) &&

+ *it != '.' && *it != '_' && *it != '-') {

LOG(WARNING) << "Failed to generate a plugin id.";

return std::string();

}