components/password_manager/core/browser/affiliation_utils.cc - Issue 1200053004: Move more string_util functions to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/affiliation_utils.cc

Issue 1200053004: Move more string_util functions to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/affiliation_utils.cc

diff --git a/components/password_manager/core/browser/affiliation_utils.cc b/components/password_manager/core/browser/affiliation_utils.cc

index 98c9099f6399bc3d9c638c4ce2d56e37f931b664..bd4bc5b2e8504b018cda2994bafab8fe7fed3151 100644

--- a/components/password_manager/core/browser/affiliation_utils.cc

+++ b/components/password_manager/core/browser/affiliation_utils.cc

@@ -43,7 +43,7 @@ base::StringPiece ComponentString(const std::string& uri,

bool ContainsOnlyAlphanumericAnd(const base::StringPiece& input,

const base::StringPiece& other_characters) {

for (char c : input) {

- if (!IsAsciiAlpha(c) && !IsAsciiDigit(c) &&

+ if (!base::IsAsciiAlpha(c) && !base::IsAsciiDigit(c) &&

other_characters.find(c) == base::StringPiece::npos)

return false;

}