content/renderer/manifest/manifest_parser.cc - Issue 1200053004: Move more string_util functions to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/manifest/manifest_parser.cc

Issue 1200053004: Move more string_util functions to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/manifest/manifest_parser.cc

diff --git a/content/renderer/manifest/manifest_parser.cc b/content/renderer/manifest/manifest_parser.cc

index 7e2fc779717d2871027969185188d4c6efa4080c..44ac56f60b695a04ab6f1d6c1de02719fb1b42c6 100644

--- a/content/renderer/manifest/manifest_parser.cc

+++ b/content/renderer/manifest/manifest_parser.cc

@@ -26,7 +26,7 @@ bool IsValidIconWidthOrHeight(const std::string& str) {

if (str.empty() || str[0] == '0')

return false;

for (size_t i = 0; i < str.size(); ++i)

- if (!IsAsciiDigit(str[i]))

+ if (!base::IsAsciiDigit(str[i]))

return false;

return true;

}