Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1200393002: Add more string_util functions to base namespace. (Closed)

Created:
5 years, 6 months ago by brettw
Modified:
5 years, 6 months ago
Reviewers:
gauravsh, sky
CC:
chromium-reviews, skanuj+watch_chromium.org, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, Michael van Ouwerkerk, browser-components-watch_chromium.org, dcheng, noyau+watch_chromium.org, tracing+reviews_chromium.org, stevenjb+watch_chromium.org, Aaron Boodman, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, vabr+watchlist_chromium.org, estade+watch_chromium.org, grt+watch_chromium.org, sdefresne+watch_chromium.org, dzhioev+watch_chromium.org, jam, ben+mojo_chromium.org, abarth-chromium, darin-cc_chromium.org, rouslan+autofillwatch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, android-webview-reviews_chromium.org, tzik, mlamouri+watch-notifications_chromium.org, Paweł Hajdan Jr., nhiroki, jfweitz+watch_chromium.org, yzshen+watch_chromium.org, oshima+watch_chromium.org, kalyank, gcasto+watchlist_chromium.org, peter+watch_chromium.org, Jered, mkwst+watchlist-passwords_chromium.org, mlamouri+watch-geolocation_chromium.org, Lei Zhang, wfh+watch_chromium.org, donnd+watch_chromium.org, tommycli, David Black, jshin+watch_chromium.org, samarth+watch_chromium.org, tfarina, kmadhusu+watch_chromium.org, darin (slow to review), kinuko+fileapi, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@string
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more string_util functions to base namespace. Moves ReplaceFirstSubstringAfterOffset. It also changes the find/replace arguments to be string pieces (normally these are constants). TBR=gauravsh@chromium.org for chromeos/network Committed: https://crrev.com/e6dae46fc681a8ad62f6937a6ac1cab3d51938a9 Cr-Commit-Position: refs/heads/master@{#335999}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -237 lines) Patch
M android_webview/native/aw_media_url_interceptor.cc View 1 2 3 1 chunk +7 lines, -6 lines 0 comments Download
M android_webview/renderer/aw_content_renderer_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/user/login_status.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/strings/string_util.h View 1 2 2 chunks +21 lines, -20 lines 0 comments Download
M base/strings/string_util.cc View 7 chunks +37 lines, -29 lines 0 comments Download
M base/trace_event/trace_event_android.cc View 3 chunks +17 lines, -19 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/fake_cws.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/login_browsertest.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/saml/saml_browsertest.cc View 1 2 4 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/test/oobe_base_test.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/system/timezone_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/commands/command_service.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/menu_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/jumplist_win.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/local_discovery/privetv3_session_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/pdf/pdf_extension_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/iframe_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/pdf/adobe_reader_info_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_dropdown.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/crash_keys.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/custom_handlers/protocol_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/importer/firefox_importer_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/profiling.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/setup_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/convert_dict/dic_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/onc/onc_utils.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M components/autofill/core/browser/data_driven_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/gcm_network_channel_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/json_schema/json_schema_validator.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/password_manager/core/browser/export/csv_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/import/csv_reader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/search_engines/template_url.cc View 3 chunks +18 lines, -16 lines 0 comments Download
M components/search_engines/template_url_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/url_fixer/url_fixer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/java/java_type.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider_linux.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/appcache_interfaces.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_launcher.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/test/net/url_request_abort_on_end_job.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/user_script_loader.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M extensions/browser/value_store/leveldb_value_store.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/error_utils.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M extensions/common/url_pattern.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/infobars/confirm_infobar_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/context.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/util/filename_util.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M net/base/filename_util.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M net/base/filename_util_internal.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/ftp/ftp_util.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M net/test/url_request/url_request_mock_http_job.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/test/url_request/url_request_slow_download_job.cc View 1 chunk +2 lines, -1 line 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/var.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M storage/browser/fileapi/file_system_url.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/boringssl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/command_args.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/gn/setup.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/webui/jstemplate_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/text_elider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/bounded_label_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/native_menu_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (11 generated)
brettw
5 years, 6 months ago (2015-06-23 22:02:20 UTC) #2
sky
LGTM
5 years, 6 months ago (2015-06-23 23:57:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200393002/20001
5 years, 6 months ago (2015-06-24 16:02:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/73609)
5 years, 6 months ago (2015-06-24 16:13:42 UTC) #7
brettw
TBR gauravsh@chromium.org for chromeos/network
5 years, 6 months ago (2015-06-24 17:20:07 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200393002/40001
5 years, 6 months ago (2015-06-24 17:33:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200393002/40001
5 years, 6 months ago (2015-06-24 17:40:43 UTC) #15
commit-bot: I haz the power
Exceeded global retry quota
5 years, 6 months ago (2015-06-24 18:21:54 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200393002/60001
5 years, 6 months ago (2015-06-24 19:09:43 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-24 20:54:58 UTC) #21
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 20:56:12 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e6dae46fc681a8ad62f6937a6ac1cab3d51938a9
Cr-Commit-Position: refs/heads/master@{#335999}

Powered by Google App Engine
This is Rietveld 408576698