Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (2/3)

Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (2/3)

This patch brought to you by:

`s/LocalCredential/PasswordCredential`
`s/CREDENTIAL_TYPE_LOCAL/CREDENTIAL_TYPE_PASSWORD`
and
`git cl format`

Patch 1 (Blink): https://codereview.chromium.org/1162443006
Patch 2 (Chromium): [This patch]
Patch 3 (Blink): https://codereview.chromium.org/1153403004

BUG=494880
R=vabr@chromium.org,jochen@chromium.org

Committed: https://crrev.com/b2135297adb1abd0cfc31a5dcb98855cb470a065
Cr-Commit-Position: refs/heads/master@{#332667}

[Mike West, 2015-06-01 08:56:37]

Even more.

[vabr (Chromium), 2015-06-01 09:55:23]

LGTM. This review brought to you by:

the compiler

(if it compiles, it looks good)

https://codereview.chromium.org/1162583003/diff/20001/ios/web/web_state/js/cr...
File ios/web/web_state/js/credential_util_unittest.mm (right):

https://codereview.chromium.org/1162583003/diff/20001/ios/web/web_state/js/cr...
ios/web/web_state/js/credential_util_unittest.mm:200: // the
nit: Please join lines 200 and 201.

[jochen (gone - plz use gerrit), 2015-06-01 13:12:58]

lgtm

[Mike West, 2015-06-03 05:41:28]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-06-03 05:43:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1162583003/20001

[commit-bot: I haz the power, 2015-06-03 05:47:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-03 05:47:20]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Mike West, 2015-06-03 09:25:45]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-06-03 09:27:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1162583003/20001

[commit-bot: I haz the power, 2015-06-03 09:32:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-03 09:32:45]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mike West, 2015-06-03 10:43:33]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2015-06-03 10:43:34]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1162583003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2015-06-03 10:44:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1162583003/40001

[commit-bot: I haz the power, 2015-06-03 10:51:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-03 10:51:17]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mike West, 2015-06-03 11:26:38]

The CQ bit was checked by mkwst@chromium.org to run a CQ dry run

[Mike West, 2015-06-03 11:26:39]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1162583003/#ps60001
(title: "Fix.")

[commit-bot: I haz the power, 2015-06-03 11:26:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1162583003/60001

[commit-bot: I haz the power, 2015-06-03 13:39:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-03 13:39:09]

Dry run: This issue passed the CQ dry run.

[Mike West, 2015-06-03 14:53:51]

mkwst@chromium.org changed reviewers:
+ stuartmorgan@chromium.org

[Mike West, 2015-06-03 14:53:52]

stuartmorgan@: Would you mind stamping the ios/web change? It should be
mechanical enough to confidently skim. :)

[stuartmorgan, 2015-06-03 16:17:23]

ios LGTM

[Mike West, 2015-06-03 19:35:02]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-06-03 19:35:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1162583003/60001

[commit-bot: I haz the power, 2015-06-03 19:45:33]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-06-03 19:47:28]

Patchset 4 (id:??) landed as
https://crrev.com/b2135297adb1abd0cfc31a5dcb98855cb470a065
Cr-Commit-Position: refs/heads/master@{#332667}